This repository was archived by the owner on Dec 2, 2024. It is now read-only.
update all deps, fix standard linting#14
Closed
achingbrain wants to merge 1 commit into
Closed
Conversation
Author
|
Depends on Level/codec#51 |
vweevers
reviewed
Jun 29, 2019
| var memdown = require('memdown') | ||
| var concat = require('concat-stream') | ||
| var levelup = require('levelup') | ||
| var level = require('level-mem') |
Member
There was a problem hiding this comment.
I prefer using level-compose because it's easier to take out encoding-down when needed. See https://github.com/vweevers/multileveldown/blob/wip-upgrade (and the discussion in Level/community#71 that spurred it).
vweevers
reviewed
Jun 29, 2019
| if (req.options.gte === null) req.options.gte = undefined | ||
| if (req.options.lt === null) req.options.lt = undefined | ||
| if (req.options.lte === null) req.options.lte = undefined | ||
| if (!req.options.gt) { |
Member
There was a problem hiding this comment.
This excludes falsy yet valid range options. A better check is == null, although that might exclude range options that are valid in bytewise. So the best solution would be if ('gt' in req.options), if we can make that work in the client-server protocol.
Member
|
Closing in favor of #15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses most recent everything & adds the
encoding-downmodule to wrap the returned client.