Skip to content
This repository was archived by the owner on Dec 2, 2024. It is now read-only.
/ party Public archive

Node.js v10 support#19

Closed
mattmorgis wants to merge 7 commits into
Level:masterfrom
mattmorgis:node-10-support
Closed

Node.js v10 support#19
mattmorgis wants to merge 7 commits into
Level:masterfrom
mattmorgis:node-10-support

Conversation

@mattmorgis
Copy link
Copy Markdown

Should close #17 and #18.

There seemed to be a few ways to go about updating this to work with Node.js v10.

I went through the process of updating level. This required wrapping multileveldown in encoding-down and cause some of the tests to fail with encoding issues. For instance, a test would want 42, but would get '42' or the Buffer for 42, but not the actual int.

An easier path seemed to keep level at v1.x, which handles encodings, and have it use v2 of leveldown. This is what my fork does.

I then updated this to use that new fork, resulting in a successful install on Node.js v10.

@achingbrain
Copy link
Copy Markdown

Hopefully this will get merged but you might be better off renaming your fork & publishing it as a new module.

@vweevers
Copy link
Copy Markdown
Member

vweevers commented Dec 8, 2019

Superseded by #20.

@vweevers vweevers closed this Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node 10

3 participants