This repository was archived by the owner on Dec 2, 2024. It is now read-only.
fix: modern Node#26
Merged
Merged
Conversation
ronag
force-pushed
the
modernize
branch
6 times, most recently
from
2a5eae0 to
b4a4f68
Compare
vweevers
suggested changes
Mar 6, 2021
Member
vweevers
left a comment
vweevers
left a comment
There was a problem hiding this comment.
Please keep the shutdown, onlistening and onopen functions, they make the code (as well as the diff of this PR) more readable. And where there's no this to worry about, let's also keep function in favor of arrow functions.
ronag
force-pushed
the
modernize
branch
2 times, most recently
from
b1fe28f to
a412073
Compare
Contributor
Author
|
Done |
ronag
commented
Mar 6, 2021
vweevers
reviewed
Mar 7, 2021
vweevers
reviewed
Mar 7, 2021
vweevers
suggested changes
Mar 7, 2021
Member
vweevers
left a comment
vweevers
left a comment
There was a problem hiding this comment.
Thanks, looks good! One last nit: remove the lockfile. Lockfiles are good for apps, not so much for modules. It doesn't apply when one does npm i level-party so as module authors we shouldn't lock either.
Contributor
Author
|
Removed |
vweevers
approved these changes
Mar 7, 2021
Member
|
5.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.