Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Remove 'march=native' flag for Apple silicon compatibility#171

Merged
vweevers merged 1 commit into
Level:masterfrom
Nazgolze:node-gyp-error-m1
Aug 1, 2021
Merged

Remove 'march=native' flag for Apple silicon compatibility#171
vweevers merged 1 commit into
Level:masterfrom
Nazgolze:node-gyp-error-m1

Conversation

@Nazgolze
Copy link
Copy Markdown
Contributor

@Nazgolze Nazgolze commented Jun 9, 2021

Closes #169

As long as folks are ok with the potential performance hit

Copy link
Copy Markdown
Member

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As written in the referenced issue, we will keep this PR open for a week.

@vweevers vweevers changed the title Remove 'march=native' line Remove 'march=native' flag for Apple silicon compatibility Jun 9, 2021
@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Jun 9, 2021
@vweevers vweevers merged commit f945be6 into Level:master Aug 1, 2021
@tommoor
Copy link
Copy Markdown

tommoor commented Aug 13, 2021

Hey, what is the timeline for a release with this fix? I'm blocked on a project as I only have M1 available and the project has a RocksDB dependency. Many thanks.

@vweevers
Copy link
Copy Markdown
Member

5.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver-patch Bug fixes that are backward compatible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node-gyp error on M1 (Apple Sillicon): errorthe clang compiler does not support '-march=native':

3 participants