[codex] add sysroot and prefix execution roots#1
Draft
veighnsche wants to merge 1 commit intomasterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
What changed
--sysrootand--prefixglobals to therecipeCLISYSROOTwhile keepingBUILD_DIRand tool-prefix paths as explicit host-side passthrough roots./..traversal and validates against sysroot escape through existing ancestorsREADME.mdsurface to match the implementationWhy
recipe bootstrapand the A/B install story were blocked on a missing canonical target-root model. This change lands that foundation in the actual owner instead of adding a shallow bootstrap wrapper on top of host-path assumptions.Impact
Recipes now receive
SYSROOTandPREFIXas standard scope constants. Absolute filesystem helper paths resolve under the chosen target sysroot by default, which makes offline, chroot, and A/B composition possible without embedding mount paths into recipes.Validation
cargo test --manifest-path tools/recipe/Cargo.toml --tests