108 text editor callout#121
Merged
emcaulay merged 7 commits intoLibraryCarpentry:gh-pagesfrom Feb 15, 2023
emcaulay:108_text_editor_callout
Merged
108 text editor callout#121emcaulay merged 7 commits intoLibraryCarpentry:gh-pagesfrom emcaulay:108_text_editor_callout
emcaulay merged 7 commits intoLibraryCarpentry:gh-pagesfrom
emcaulay:108_text_editor_callout
Conversation
ErinBecker
approved these changes
Oct 18, 2021
Contributor
ErinBecker
left a comment
ErinBecker
left a comment
There was a problem hiding this comment.
This looks great to me! I've only made two small suggestions.
Co-authored-by: Erin Becker <ebecker@carpentries.org>
Co-authored-by: Erin Becker <ebecker@carpentries.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR involves a few different changes.
One part fixes #108. I've made a very small callout inside episode 2 to discuss the wide world of text editors and why we recommend nano for this lesson.
For reviewers, I welcome your suggestions about whether the callout should be moved to the bottom of the episode or stay where it is.
Also, I think that adding something about text editors to the Instructor Notes is a good idea, but I will do that separately.
This PR also involves a very small edit to the Instructor's Notes about a known problem with Windows and Open SSH. I confess that I don't fully understand the problem yet, so this is more of an early warning to instructors. I will try to address it more fully in a subsequent PR, but for now, at least it's the beginning of a warning and hint for instructors about this problem.
By the way, I now know that I made the mistake of creating a new branch using another branch that had not yet been merged instead of starting from gh-pages for each of the changes I was making. I plan to avoid that mistake next time I have a change to make!