Skip to content

add details to setup page for git install and config#42

Closed
evanwill wants to merge 1 commit intoLibraryCarpentry:gh-pagesfrom
evanwill:gh-pages
Closed

add details to setup page for git install and config#42
evanwill wants to merge 1 commit intoLibraryCarpentry:gh-pagesfrom
evanwill:gh-pages

Conversation

@evanwill
Copy link
Copy Markdown
Contributor

added updated details about installing git and configuring locally.
the original instructions were based on SWC, where there is centralized set up instructions provided in the "workshop template". Library Carpentry lessons seem more stand alone, so we can't be sure that participants have done a centralized set up, so I hope this ensures clarity for everything needed for the Git lesson.

it suggests everyone use Nano editor as default, since it is installed by default in MacOS and Linux, and is bundled with Git for Windows, and seems easiest to explain when it pops up during a merge.

@evanwill evanwill mentioned this pull request Dec 19, 2018
@katrinleinweber
Copy link
Copy Markdown
Contributor

OK, thanks! I suggest we wait with reviewing this until we have #41 merged. There is also #7 seems to partially overlap with this PR.

@katrinleinweber
Copy link
Copy Markdown
Contributor

katrinleinweber commented Dec 20, 2018

I merged #41 now, because it fixed an actually out-dated piece of info.

With #7, we basically have two competing PRs about the same topic here. I wonder whether we should forgo refining our own version of the setup and instead refer directly to SwCarpentry.GitHub.io/git-novice/02-setup?

@katrinleinweber
Copy link
Copy Markdown
Contributor

katrinleinweber commented Dec 20, 2018

@evanwill: Because you started this PR from your gh-pages branch, I was warned by GitHub when I wanted to resolve the conflict just now. Please resolve the conflict and in the future always add commits to a branch other than master or gh-pages. Thank you!

@libcce
Copy link
Copy Markdown

libcce commented Dec 20, 2018

SwCarpentry.GitHub.io/git-novice/02-setup

This makes better sense to me.

@evanwill
Copy link
Copy Markdown
Contributor Author

@libcce and @katrinleinweber the lesson needs instructions to 1. install Git and 2. Configure Git.
I think the SWC approach of having the configuration step as part of the lesson (the Setting up git page you referred to), so it can be part of the learning process, makes the most sense--I fleshed it out here because the current LC-git lesson doesn't have configuration anywhere else.

i think i will just close this and open an issue for discussion

@katrinleinweber
Copy link
Copy Markdown
Contributor

I'm fine with discussing it here. Please feel free to add a commit that implements a reference to SwCarpentry.GitHub.io/git-novice/02-setup and I'll re-open this.

@katrinleinweber
Copy link
Copy Markdown
Contributor

@libcce: If we are still in agreement about #42 (comment), we can close #7.

@libcce
Copy link
Copy Markdown

libcce commented Mar 11, 2019

@katrinleinweber We can at least close #7. I agree.

@katrinleinweber
Copy link
Copy Markdown
Contributor

@dheles: What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants