Unit tests fails during dailight saving change period

[hakito]

The test ScheduleTotalConcurrentReservationsRuleTest::testChecksEachInstanceOfASeries fails on 2nd November 2024.

The reason seems to be that on line

app/Domain/ReservationSeries.php

Line 311 in 7a763d9

$dates = $repeatOptions->GetDates($this->CurrentInstance()->Duration()->ToTimezone($this->_bookedBy->Timezone));

the calculated dates are calculated for the time zone of the 'booker' which is New York.

The DateRange class or Date seems to have timezone based conversions, but something must go wrong.

[github-actions]

This issue was marked stale because it has been open 60 days with no activity. Please remove the stale label or comment on this issue. Otherwise, it will be closed in 15 days.

[JohnVillalovos]

@hakito This might be the same as #544

[hakito]

Probably - I remember that when looking at the code the custom time conversion was kinda weird.