Infinite loop of reloading Login page (opened via http) if browser locale is different from en_US

[Slenkis]

LibreBooking info:

• Project version: v2.8.6.2 (docker image tag = librebooking:develop)
• Enviroment: run in docker-compose version 1.29.2

via this configuration:

docker-compose.yml

version: "3.7"

services:
  db:
    image: linuxserver/mariadb:10.6.13
    restart: always
    networks:
      - mynet
    volumes:
      - db_conf:/config
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Europe/Zurich
      - MYSQL_ROOT_PASSWORD=maria123
  app:
    image: librebooking/librebooking:develop
    restart: always
    depends_on:
      - db
    networks:
      - mynet
    ports:
      - "80:80"
    volumes:
      - app_conf:/config
    environment:
      - LB_DB_NAME=librebooking
      - LB_DB_USER=lb_user
      - LB_DB_USER_PWD=lb123
      - LB_DB_HOST=db
      - LB_INSTALL_PWD=install123
      - LB_ENV=dev
      - LB_LOG_FOLDER=/var/log/librebooking
      - LB_LOG_LEVEL=debug
      - LB_LOG_SQL=false
      - TZ=Europe/Zurich

volumes:
  db_conf:
  app_conf:

networks:
  mynet:

Browser info:

• Locale: de-DE (problem with any locale other than en_US)
• Google Chrome 134.0.6998.118 (Offical build) (64 bit) (cohort: Stable) and other browsers

Behavior:

1. Open url: http://10.20.1.102/Web/index.php
2. The page detects the browser locale and makes a GET request to http://10.20.1.102/Web/index.php?lang=de_de
3. Receives a response with a 302 code and a header (for example):

set-cookie:
language=de_de; expires=Mon, 21 Apr 2025 18:45:05 GMT; Max-Age=2592000; secure; HttpOnly; SameSite=Lax

4. Since the cookie has the secure flag set, it cannot be set.
5. The page reloads and so on in a loop.

Video proof:

librebooking_issuse_login_page_loop_with_another_languages.mp4

[Slenkis]

let's talk about this problem?
@effgarces
@labmecanicatec
@lucs7

[lucs7]

Can u try the current develop version and see if the problem persists?

[Slenkis]

Can u try the current develop version and see if the problem persists?

In my first post is docker-compose.yml, there is a line with the version (I used develop anyway)

  app:
    image: librebooking/librebooking:develop

I have completely cleaned docker from previous versions with these commands:

docker system prune --all
docker volume prune

then ran it with this command:

docker-compose up --detach

I can't guarantee that it's the latest version, but the behavior hasn't changed. I should probably either switch to https (but can librebooking listen on port 443?) or disable the cookie's secure flag.

[jgr123]

I have the same problem. I'm using only http.

[lucs7]

I tried to reproduce the issue with a very basic compose file and http. Unfortunately I do not see the reload issue but I did have it before. Can you delete the browser cookies. maybe that will resolve the problem as the language key on localhost might be set by another local testing application.

networks:
  librebooking:

services:
  librebooking:
    image: librebooking/librebooking:develop
    container_name: librebooking
    restart: always
    depends_on:
      mariadb:
        condition: service_healthy
        restart: true
    ports:
      - 8085:80
    networks:
      - librebooking
    environment:
      - LB_DB_HOST=mariadb
      - LB_DB_NAME=lb
      - LB_DB_USER=root
      - LB_DB_USER_PWD=devpass
      - LB_INSTALL_PWD=devpass
      - LB_LOG_LEVEL=debug
      - TZ="Europe/Berlin"

  mariadb:
    image: mariadb:latest
    container_name: mariadb2
    networks:
      - librebooking
    healthcheck:
      test: ["CMD", "healthcheck.sh", "--connect", "--innodb_initialized"]
      start_period: 10s
      interval: 10s
      timeout: 5s
    environment:
      MYSQL_ROOT_PASSWORD: devpass
      MYSQL_DATABASE: lb

[Slenkis]

Here's the log of the application container (1.2.2.253 its my PC):

 [php:warn] [pid 80:tid 80] [client 1.2.2.253:31526] PHP Warning:  Undefined array key "HTTPS" in /var/www/html/lib/Server/Server.php on line 271, referer: http://10.20.1.102:81/Web/dashboard.php

Here is the ⚠warning in Google Chrome. the same error is in Microsoft Edge (134.0.3124.93), but it does not reload the page in a loop:

[Slenkis]

@lucs7,
@jgr123,

I made an HTTPS connection to libreboking:develop via Cloudflare. This partially solved the problem. The language started to change to the one I selected from the list, the login page loaded in that language, but after a few seconds the page language was reset to the browser locale again....

Then I installed the stable version v2.8.6.2 and the problem was solved completely.
Even through HTTP connection!

There were also other minor bugs on the develop version, so I will leave the stable version for production.

[cmagowan]

I am experienceing the same issue.
New install of release v2.8.6.2.
Site works 100% fine on windows PC, i tried it in both firefox and chrome.
It also works fine on android using "samsung internet"
However, when used on the iphone it repeatedly loads as shown above in both chrome and safari.
On mac (15.4) Safari (18.4) loops, but chrome and firefox are fine.
This is with the language as English GB, using https, but still does it when i changed to English US.
I'm in the UK.

[Robinwhood]

Fixed the issue by removing the readCookie JS in: app/tpl/login.tpl on line 142.

var langCode = readCookie('{CookieKeys::LANGUAGE}');

        if (!langCode) {
            langCode = (navigator.language + "").replace("-", "_").toLowerCase();

            var availableLanguages = [{foreach from=$Languages item=lang}"{$lang->GetLanguageCode()}",{/foreach}];
            if (langCode !== "" && langCode != '{$SelectedLanguage|lower}') {
            if (availableLanguages.indexOf(langCode) !== -1) {
                window.location.href = url + langCode;
            }
        }
    }

[belcirelk]

For some reasons, if I get the cookie value in the tpl instead of the javascript it works. That way I can still keep the default language redirect. I think it's because the cookie is httponly and thus not available via javascript.

var langCode = '{$smarty.cookies.language|escape:"javascript"}';

        if (!langCode) {
            langCode = (navigator.language + "").replace("-", "_").toLowerCase();

            var availableLanguages = [{foreach from=$Languages item=lang}"{$lang->GetLanguageCode()}",{/foreach}];
            if (langCode !== "" && langCode != '{$SelectedLanguage|lower}') {
            if (availableLanguages.indexOf(langCode) !== -1) {           
                window.location.href = url + langCode;
            }
        }
    }

[erickbarros311]

PRELIMINARIES: we believe that this issue occurs because the langCode variable fails to retrieve the browser cookie using the function:

readCookie('{CookieKeys::LANGUAGE}');

As a result, langCode remains empty.

When the conditional statement evaluates the current language setting in:

if (langCode !== "" && langCode != '{$SelectedLanguage|lower}')

the empty langCode forces the code to execute:

if (availableLanguages.indexOf(langCode) !== -1)

which then redirects the page to the default language, en_us.

--------------------------How we fixed the bug (our default language is Brazilian Portuguese):------------------------------

1.We explicitly set the default language in the main configuration file at:

/var/www/html/app/config/config.php

by assigning:

$conf['settings']['default.language'] = 'pt_br';

2.We updated the database to set all users’ default language to "pt_br" with the following query:

UPDATE librebooking.users SET language = 'pt_br';

3. We edited the application’s global template file located at:

/var/www/html/app/tpl/login.tpl

Specifically, on line 165

We disabled the default Smarty-based language extraction:

// var langCode = '{$smarty.cookies.language|escape:"javascript"}';

• We kept the original cookie read statement:

var langCode = readCookie('{CookieKeys::LANGUAGE}');

• But we overrode the value of langCode explicitly:

langCode = 'pt_br';

This ensures that the langCode variable is always set to the desired language when the conditional logic runs.

-----------------------------------Final working code snippet:-----------------------------

`<script type="text/javascript">
var url = 'index.php?{QueryStringKeys::LANGUAGE}=';
$(document).ready(function() {
$('#languageDropDown').change(function() {
window.location.href = url + $(this).val();
});
// var langCode = '{$smarty.cookies.language|escape:"javascript"}';
var langCode = readCookie('{CookieKeys::LANGUAGE}');
langCode = 'pt_br';

    if (!langCode) {
        langCode = (navigator.language + "").replace("-", "_").toLowerCase();

        var availableLanguages = [{foreach from=$Languages item=lang}"{$lang->GetLanguageCode()}",{/foreach}];
        if (langCode !== "" && langCode != '{$SelectedLanguage|lower}') {
            if (availableLanguages.indexOf(langCode) !== -1) {
                window.location.href = url + langCode;
            }
        }
    }
});

</script> `