Possible bug in reservation reminders

[cgutteridge]

I think I've found a bug. I'd like another pair of eyes to look at it and confirm, and if someone else agrees I'll do a PR.

Describe the bug**

Our users are reporting that they are getting reminder emails for cancelled reservations.

To Reproduce**

Steps to reproduce the behavior:

1. Have n instance with reminder notifications turned on
2. create a booking
3. cancel that booking
4. Still get email

Expected behavior**

Don't get reminders for cancelled bookings.

Specifications

• LibreBooking version librebooking-2.8.6.2-GA4-Fix.zip

This looks to be a logic error in https://github.com/LibreBooking/app/blob/3571cb74dee6d640dee3bfa824b7f3bcb29ca4d3/lib/Database/Commands/Queries.php#L672C1-L672C309

It looks to need brackets around the long OR statement as the status<>2 is only filtering the first kind of reminder.

[belcirelk]

Hi,

I tried to reproduce this bug with version 3.0.3 and I was not able on my side.

[cgutteridge]

To be clear, we are getting:
On a normal reservation:

• "your reservation is starting soon" email
• "your reservation is ending soon" email
  On a cancelled reservation:
  "your reservation is ending soon" email

This is due to a missing set of brackets in the SQL query that only filters for cancellation emails on "starting" reservations, not "ending" as it does A AND B OR C but should be A AND (B OR C)

[belcirelk]

I misunderstood, I checked only the starting soon email, not the ending.

[cgutteridge]

It's subtle. I've attempted to make a pull request for the fix which worked for us, but it is rejecting-- I think maybe I need to say magic words in the commit message?