fix: don't attempt to reserve view-only resource #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the UI to hide reservation options for resources where the user only has view-only permissions.
- Replaced permission checks from
CanAccesstoCanBookto control both the “reserve” link visibility and individual slot display.
Comments suppressed due to low confidence (1)
tpl/Schedule/schedule-reservations-grid.tpl:36
- Consider adding a UI or integration test to verify that reservation links are hidden for resources where
CanBookis false, ensuring view-only resources cannot be reserved.
{if $resource->CanBook && $DailyLayout->IsDateReservable($date)}
Contributor
Author
|
With this PR I now see this in the UI
Conference Room 1 has been to to ViewOnly for the user. |
JohnVillalovos
force-pushed
the
jlvillal/issue_655
branch
from
2c06b62 to
1ca7ed0
Compare
Previously a user could attempt to reserve a resource that they had "view-only" permission. The reservation would then fail. Change the UI so that it doesn't offer them the option to reserve the resource. Closes: #655
JohnVillalovos
force-pushed
the
jlvillal/issue_655
branch
from
1ca7ed0 to
e64d5f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a user could attempt to reserve a resource that they had "view-only" permission. The reservation would then fail.
Change the UI so that it doesn't offer them the option to reserve the resource.
Closes: #655