chore: Replace jQuery UI datepicker with flatpickr #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request replaces the jQuery UI datepicker implementation with flatpickr to provide a more modern and maintainable date picker solution. The change includes updating the necessary templates, JavaScript logic, and styling to work with the new flatpickr library.
Key changes:
- Integration of flatpickr library assets (JavaScript and CSS) conditionally loaded based on DatePicker template variable
- Complete rewrite of DatePickerSetup.tpl to use flatpickr configuration instead of jQuery UI
- Updated schedule.js to handle flatpickr's different callback signature and date object handling
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tpl/javascript-includes.tpl | Adds conditional flatpickr JavaScript includes for both local and CDN scenarios |
| tpl/globalheader.tpl | Adds conditional flatpickr CSS includes for both local and CDN scenarios |
| tpl/Schedule/schedule.tpl | Enables DatePicker flag and updates UI elements for better date selection |
| tpl/Controls/DatePickerSetup.tpl | Complete rewrite from jQuery UI datepicker to flatpickr configuration |
| Web/scripts/schedule.js | Updates date handling functions to work with flatpickr's callback signature |
| Web/css/schedule.css | Removes jQuery UI datepicker-specific styling |
| Web/css/librebooking.css | Adds flatpickr-specific styling to match application theme |
Switched the datepicker implementation from jQuery UI to flatpickr for improved UI and maintainability. Added flatpickr assets, updated styles in librebooking.css, removed jQuery UI datepicker-specific styles from schedule.css, and updated relevant templates and JavaScript to use flatpickr.
JohnVillalovos
force-pushed
the
flatpickr
branch
from
af7758f to
5305903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the datepicker implementation from jQuery UI to flatpickr for improved UI and maintainability. Added flatpickr assets, updated styles in librebooking.css, removed jQuery UI datepicker-specific styles from schedule.css, and updated relevant templates and JavaScript to use flatpickr.