refactor: timezone handling and remove jstz library #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the manual timezone list in config/timezones.php with dynamic generation using DateTimeZone::listIdentifiers(). Removed the jstz.min.js library and updated register.tpl to use the native Intl.DateTimeFormat API for timezone detection, simplifying the code and reducing dependencies.
JohnVillalovos
approved these changes
Jul 30, 2025
Contributor
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
LGTM
Thanks @labmecanicatec
There was a problem hiding this comment.
Pull Request Overview
This PR refactors timezone handling by replacing the hardcoded timezone list with dynamic generation using PHP's DateTimeZone API, and simplifies client-side timezone detection by removing the jstz.min.js dependency in favor of the native Intl.DateTimeFormat API.
- Replaced manual timezone list with
DateTimeZone::listIdentifiers()for dynamic timezone generation - Removed jstz.min.js dependency and updated JavaScript to use native
Intl.DateTimeFormatAPI - Simplified timezone detection logic with fallback to "UTC"
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| config/timezones.php | Replaced 400+ hardcoded timezone entries with dynamic generation using DateTimeZone::listIdentifiers() |
| tpl/register.tpl | Removed jstz.min.js dependency and updated JavaScript to use native browser APIs for timezone detection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the manual timezone list in config/timezones.php with dynamic generation using DateTimeZone::listIdentifiers(). Removed the jstz.min.js library and updated register.tpl to use the native Intl.DateTimeFormat API for timezone detection, simplifying the code and reducing dependencies.