Fix for phpunit tests and additional error check #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to docker container, config.dist.php files are copied to config folder and used as basis for tests silent fail on phpunit run are checked through logging output
set ResourceRepositoryTest to BROKEN state, as it is not compatible with the current codebase enable other tests
JohnVillalovos
approved these changes
Aug 2, 2025
Contributor
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
LGTM
Thanks @lucs7 I cleaned up the commit messages a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the ImportICalPresenterTest tests silently failing, phpunit did fail before running all tests. Now the workflow checks for the OK message in the phpunit log.
In addition this PR fixes the
Plugin tests have been fixed by adding provision of plugin configs based on their config.dist.php files
ResourceRepositoryTest has been marked as broken as it is not compatible with #681 @JohnVillalovos