Skip to content

Conversation

@maggienegm
Copy link
Contributor

Added an admin.php file to handle multiple sites and their respective setup and configuration. You have to manually type the URL to access admin.php, which requires user authentication before its contents are accessed. Currently, it includes the following functionalities:

  • Upgrade Database (setup/sql_upgrade.php)
  • Access Control Upgrade (acl_upgrade.php)
  • Patch Database (sql_patch.php)

This will help prevent unauthenticated info disclosure and unauthenticated admin actions.

Context: PR 1638

Copy link
Contributor

@aethelwulffe aethelwulffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to check out the paradigm that the site "default" is never actually used for a clinic. Among other things, it really helps when a running install is also a repo, so the local DB/site files can always have a .gitignore to keep them untracked, while the base code gets updated...and PR's/branches can come straight off the running code, or test new code too.

@maggienegm
Copy link
Contributor Author

Hmmm, I thought "default" was just a value; "default" is a site ID name and is the default value when creating a site using setup.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants