This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Use hash set instead of array list for performance#7
Merged
TheDGOfficial merged 3 commits intomainfrom Feb 17, 2021
Merged
Conversation
We only use the contains and add methods, and do not add duplicate entries, and we use String, each String should have unique hash code. So, by using HashSet instead of ArrayList, we can gain a performance improvement somewhere between %5 to %10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in this Pull Request
Changed duplicate entry tracker to use HashSet instead of ArrayList for performance.
Reason of the above changes are
We only use the contains and add methods, we are not adding duplicate entries, and we use String, each String should have unique hash code. So, we can use HashSet instead.
Other information about this Pull Request
By using HashSet instead of ArrayList, we can gain a performance improvement.
ArrayList#contains compute time is O(n), where as HashSet's one is O(1). So, the more entries on the ArrayList, the more time it will take for the contains method.