Skip to content

[BOOKINGSG-8012][XY] add merge icon#39

Merged
qroll merged 4 commits intomainfrom
BOOKINGSG-8012
Oct 6, 2025
Merged

[BOOKINGSG-8012][XY] add merge icon#39
qroll merged 4 commits intomainfrom
BOOKINGSG-8012

Conversation

@sarahchenxy
Copy link
Contributor

@sarahchenxy sarahchenxy commented Oct 2, 2025

Changes
add merge icon

  • delete branch

Changelog entry

  • add merge icon

Additional information
figma

Copy link
Contributor

@qroll qroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! The format of the SVG seems different from the existing ones. Could you re-export the svg asset from the Figma icon library and replace the file here?

@sarahchenxy
Copy link
Contributor Author

Hi! The format of the SVG seems different from the existing ones. Could you re-export the svg asset from the Figma icon library and replace the file here?

is there a specific weight/grade/optical size that i should follow ?

@qroll
Copy link
Contributor

qroll commented Oct 3, 2025

Hi! The format of the SVG seems different from the existing ones. Could you re-export the svg asset from the Figma icon library and replace the file here?

is there a specific weight/grade/optical size that i should follow ?

The one in Figma should already be following the existing specs, you can export it directly from there

@sarahchenxy
Copy link
Contributor Author

Hi! The format of the SVG seems different from the existing ones. Could you re-export the svg asset from the Figma icon library and replace the file here?

is there a specific weight/grade/optical size that i should follow ?

The one in Figma should already be following the existing specs, you can export it directly from there

oh i see! ok thanks

@qroll qroll merged commit 6dda558 into main Oct 6, 2025
1 check failed
@qroll qroll deleted the BOOKINGSG-8012 branch October 6, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments