Closed
Conversation
SwenSchaeferjohann
requested review from
ananas-block and
sergeytimoshin
as code owners
SwenSchaeferjohann
force-pushed
the
swen/rm-merkle-context
branch
from
edbf36a to
54c6c6c
Compare
ananas-block
reviewed
Jun 7, 2025
ananas-block
reviewed
Jun 7, 2025
| // ), | ||
| // }, | ||
| // context: res.result.context, | ||
| // }; |
Contributor
Author
There was a problem hiding this comment.
no, must add v1 support
ananas-block
reviewed
Jun 7, 2025
| // export type CompressedAccountWithMerkleContext = CompressedAccount & | ||
| // MerkleContext & { | ||
| // readOnly: boolean; | ||
| // }; |
ananas-block
reviewed
Jun 7, 2025
ananas-block
reviewed
Jun 7, 2025
| export function getTreeInfoByPubkey( | ||
| treeInfos: TreeInfo[], | ||
| treeOrQueue: PublicKey, | ||
| ): TreeInfo { |
Contributor
There was a problem hiding this comment.
in light-client we currently don't expose such function, we just use it under the hood because ideally it should only be an intermediate solution.
In the future photon v2 api calls should provide all tree info.
Contributor
Author
There was a problem hiding this comment.
it's a utility to filter an existing array of TreeInfos you pass in by some identifier (tree or queue pubkey)
useful for test constructions where you want to select a specific tree for example after you call getStateTreeInfos()
ananas-block
reviewed
Jun 7, 2025
ananas-block
reviewed
Jun 7, 2025
SwenSchaeferjohann
force-pushed
the
v2-only
branch
from
463cd02 to
9c08675
Compare
SwenSchaeferjohann
force-pushed
the
swen/rm-merkle-context
branch
from
69e582d to
bf07379
Compare
SwenSchaeferjohann
force-pushed
the
v2-only
branch
from
9c08675 to
7e607c0
Compare
SwenSchaeferjohann
force-pushed
the
swen/rm-merkle-context
branch
from
0e36f0e to
6907785
Compare
* stateless.js add treeinfos * wip * add getTokenPoolInfos * wip * wip * wip - storageoptions * wip * wip * wip * wip - known bug in rpc-interop.test.ts if using random trees * debugged test-rpc in ctoken * all ctoken tests working * rm logs * clean * ctxs to infos, removed redundant getMintProgramId calls * rm deadcode, storageoptions * fix cli getMindProgramId use * fix tokenpool * fix test stateless.js add treeinfos wip add getTokenPoolInfos wip wip wip - storageoptions wip wip wip wip - known bug in rpc-interop.test.ts if using random trees debugged test-rpc in ctoken all ctoken tests working rm logs clean ctxs to infos, removed redundant getMintProgramId calls rm deadcode, storageoptions fix cli getMindProgramId use fix tokenpool fix test update CHANGELOG.md files update changelog update CHANGELOG.md export get-token-pool-infos.ts wip clean wip refactor merklecontext refactor StateTreeInfo wip wip debug test-rpc getCompressedTokenAccountsByOwner fix unit test wip wip wip debug .readUIntLE wip wip wip fix buffer conversion at test-rpc decode wip tests working compressedProof -> validityProof update changelog wip refactor: do not allow output trees for decompress, transfer fmt wip rename getCachedStateTreeInfos upd changelog use with getCachedStateTreeInfos getStateTreeInfos wip wip delegate test wip added transfer-delegated.test.ts added transfer-delegated test cases. all green add tests for decompress-delegated fix rm logs from program update changelog update err msg fix state-tree-luts wip getActiveStateTreeInfos -> getAllStateTreeInfos wip fix sigs for nullifyStateTree wip wip cleanup add getCachedActiveStateTreeInfos mock revert to compressedProof add tokenpools tests update comment update CHANGELOG.md update changelog 0.21.0 update changelog fix fix event parsing post rebase stateless js refactor dedupe types link to computebudgetprogram wip fix DX for instructions: add docstrings to call signatures wip dont break mergeTokenAccounts wip wip add v2 trees to test-rpc v1 mergeable test-rpc tests working rpc-interop tests working with v2 all stateless.js tests working with v2 compressed-token tests working rebase to main fixup cargo lock wip chore: backport breaking api changes to v1 js SDKs (#1661) * stateless.js add treeinfos * wip * add getTokenPoolInfos * wip * wip * wip - storageoptions * wip * wip * wip * wip - known bug in rpc-interop.test.ts if using random trees * debugged test-rpc in ctoken * all ctoken tests working * rm logs * clean * ctxs to infos, removed redundant getMintProgramId calls * rm deadcode, storageoptions * fix cli getMindProgramId use * fix tokenpool * fix test stateless.js add treeinfos wip add getTokenPoolInfos wip wip wip - storageoptions wip wip wip wip - known bug in rpc-interop.test.ts if using random trees debugged test-rpc in ctoken all ctoken tests working rm logs clean ctxs to infos, removed redundant getMintProgramId calls rm deadcode, storageoptions fix cli getMindProgramId use fix tokenpool fix test update CHANGELOG.md files update changelog update CHANGELOG.md export get-token-pool-infos.ts wip clean wip refactor merklecontext refactor StateTreeInfo wip wip debug test-rpc getCompressedTokenAccountsByOwner fix unit test wip wip wip debug .readUIntLE wip wip wip fix buffer conversion at test-rpc decode wip tests working compressedProof -> validityProof update changelog wip refactor: do not allow output trees for decompress, transfer fmt wip rename getCachedStateTreeInfos upd changelog use with getCachedStateTreeInfos getStateTreeInfos wip wip delegate test wip added transfer-delegated.test.ts added transfer-delegated test cases. all green add tests for decompress-delegated fix rm logs from program update changelog update err msg fix state-tree-luts wip getActiveStateTreeInfos -> getAllStateTreeInfos wip fix sigs for nullifyStateTree wip wip cleanup add getCachedActiveStateTreeInfos mock revert to compressedProof add tokenpools tests update comment update CHANGELOG.md update changelog 0.21.0 update changelog fix fix event parsing post rebase stateless js refactor dedupe types link to computebudgetprogram wip fix DX for instructions: add docstrings to call signatures wip dont break mergeTokenAccounts wip wip add v2 trees to test-rpc v1 mergeable test-rpc tests working rpc-interop tests working with v2 all stateless.js tests working with v2 compressed-token tests working rebase to main fixup cargo lock wip wip rename statetreeinfo -> treeinfo wip wip wip cli test works wip
SwenSchaeferjohann
force-pushed
the
swen/rm-merkle-context
branch
from
6907785 to
0fb2696
Compare
SwenSchaeferjohann
force-pushed
the
v2-only
branch
from
7e607c0 to
d235ce2
Compare
Contributor
Author
|
closing in favor of https://github.com/Lightprotocol/light-protocol/pull/1794/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.