Skip to content

chore: bump pinocchio to v0.9#1955

Merged
SwenSchaeferjohann merged 2 commits intomainfrom
jorrit/chore-bump-pinocchio-0.9
Oct 3, 2025
Merged

chore: bump pinocchio to v0.9#1955
SwenSchaeferjohann merged 2 commits intomainfrom
jorrit/chore-bump-pinocchio-0.9

Conversation

@ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Oct 3, 2025

Summary by CodeRabbit

  • Chores

    • Updated core dependencies to newer versions for improved compatibility and future-proofing.
  • Refactor

    • Reduced use of unsafe operations in system logging paths to enhance safety.
  • Tests

    • Streamlined test setups by removing unnecessary cloning for faster, more reliable execution.
    • Added explicit panic capture in specific edge-case tests.
    • Adjusted test data initialization to better reflect intended validation scenarios.
  • Documentation

    • No user-facing documentation changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Walkthrough

Updates workspace and system program pinocchio dependencies, removes an unsafe dereference in system account checks, and refactors multiple tests to avoid cloning by moving/borrowing AccountInfo values; one test now captures a panic explicitly.

Changes

Cohort / File(s) Summary of Changes
Workspace dependency bump
Cargo.toml
Bumped pinocchio in [workspace.dependencies] from 0.8.4 to 0.9.
System program dependency bump
programs/system/Cargo.toml
Updated pinocchio-system from 0.2.3 to 0.3.0.
Safety cleanup in account checks
programs/system/src/accounts/account_checks.rs
Removed an unsafe dereference around owner() in a log message and used the direct value instead; no control-flow change.
Tests: ownership / clone-to-move refactor
programs/system/tests/invoke_cpi_instruction.rs, programs/system/tests/invoke_cpi_instruction_v2.rs, programs/system/tests/invoke_instruction.rs
Replaced .clone() usage with moves/borrows for AccountInfo values and adjusted mutability; one failing test path wrapped to capture a panic.
Test helper data layout change
program-libs/account-checks/src/account_info/test_account_info.rs
Initialized borrow_state to 0xFF instead of 0; changed offset-4 field from u32 original_data_len to i32 resize_delta (writes 0i32 instead of 0u32).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sergeytimoshin
  • SwenSchaeferjohann

Poem

A rabbit hops with tidy paws,
no unsafe edges, just new laws.
Dependencies sprout fresh and spry,
tests move gently, clones say bye.
If panic blooms, we’ll catch and cheer—🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “chore: bump pinocchio to v0.9” succinctly and accurately captures the primary change of updating the pinocchio dependency to version 0.9 across the workspace and related crates, without extraneous details. It is concise, specific, and clearly communicates the intent of the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jorrit/chore-bump-pinocchio-0.9

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8205c49 and e51b699.

📒 Files selected for processing (1)
  • program-libs/account-checks/src/account_info/test_account_info.rs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • program-libs/account-checks/src/account_info/test_account_info.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: stateless-js-v2
  • GitHub Check: Forester e2e test
  • GitHub Check: cli-v2
  • GitHub Check: cli-v1
  • GitHub Check: stateless-js-v1
  • GitHub Check: lint
  • GitHub Check: system-programs (sdk-anchor-test-program, ["cargo-test-sbf -p sdk-anchor-test", "cargo-test-sbf -...
  • GitHub Check: system-programs (sdk-libs, light-sdk-macros light-sdk light-program-test light-client light-batch...
  • GitHub Check: system-programs (sdk-test-program, ["cargo-test-sbf -p sdk-native-test", "cargo-test-sbf -p sdk-v...
  • GitHub Check: Test concurrent-merkle-tree
  • GitHub Check: Test program-libs-slow
  • GitHub Check: system-programs (system-cpi-test-v2-other, ["cargo-test-sbf -p system-cpi-v2-test -- --skip funct...
  • GitHub Check: Test batched-merkle-tree-simulate
  • GitHub Check: Test program-libs-fast
  • GitHub Check: system-programs (light-registry, ["cargo-test-sbf -p registry-test"])
  • GitHub Check: system-programs (random-e2e-test, ["cargo-test-sbf -p e2e-test"])
  • GitHub Check: system-programs (system-cpi-test-v2-event, ["cargo-test-sbf -p system-cpi-v2-test -- event::parse"])
  • GitHub Check: system-programs (light-system-program, ["cargo-test-sbf -p system-test"])
  • GitHub Check: system-programs (system-cpi-test-v2-functional, ["cargo-test-sbf -p system-cpi-v2-test -- functio...
  • GitHub Check: system-programs (account-compression, ["cargo-test-sbf -p account-compression-test"])
  • GitHub Check: system-programs (system-cpi-test, ["cargo-test-sbf -p system-cpi-test", "cargo test -p light-syst...
  • GitHub Check: system-programs (light-compressed-token, ["cargo-test-sbf -p compressed-token-test"])

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SwenSchaeferjohann SwenSchaeferjohann merged commit e9056e4 into main Oct 3, 2025
32 checks passed
@SwenSchaeferjohann SwenSchaeferjohann deleted the jorrit/chore-bump-pinocchio-0.9 branch October 3, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants