refactor: remove bump from create mint instruction data#2048
Merged
sergeytimoshin merged 1 commit intomainfrom Nov 14, 2025
Merged
refactor: remove bump from create mint instruction data#2048sergeytimoshin merged 1 commit intomainfrom
sergeytimoshin merged 1 commit intomainfrom
Conversation
Contributor
WalkthroughThe pull request removes the Changes
Sequence DiagramsequenceDiagram
participant Client
participant SDK as SDK Layer
participant Program as Program Logic
participant Chain as Blockchain
Note over Client,Program: Previous Flow (with mint_bump)
Client->>SDK: create_mint(seed, bump)
SDK->>Program: validate bump matches PDA
Program->>Program: create_program_address(seed, bump)
Program-->>Chain: Verify PDA matches input
Note over Client,Program: New Flow (no mint_bump)
Client->>SDK: create_mint(seed)
SDK->>Program: derive PDA
Program->>Program: find_program_address(seed)
Program-->>Chain: Use derived address directly
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes The changes are cohesive in intent—removing bump seed handling throughout the stack—but require careful verification across multiple layers:
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
sergeytimoshin
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Changes:
mint_bumpfrom create mint instruction dataSummary by CodeRabbit
Release Notes