[WIP] Update solana-test-validator command in READMEs and scripts#22
[WIP] Update solana-test-validator command in READMEs and scripts#22vadorovsky wants to merge 1 commit intomainfrom
Conversation
We don't have to use a cloned Solana repo anymore, the newest testnet versions of Solana CLI tools are working fine.
| --bpf-program J1RRetZ4ujphU75LP8RadjXMf3sA12yC2R44CF7PmU7i ./target/deploy/verifier_program_zero.so \ | ||
| --bpf-program JA5cjkRJ1euVi9xLWsCJVzsRzEkT8vcC4rqw9sVAo5d6 ./target/deploy/merkle_tree_program.so \ | ||
| --bpf-program 3KS2k14CmtnuVv2fvYcvdrNgC94Y11WETBpMUGgXyWZL ./target/deploy/verifier_program_one.so \ | ||
| --bpf-program noopb9bkMVfRPU8AsbpTUg8AQkHtKwMYZiFUjNRtMmV ../../solana/web3.js/test/fixtures/noop-program/solana_sbf_rust_noop.so \ |
There was a problem hiding this comment.
@ananas-block This doesn't exist enymore in Solana repo, all the web3.js got removed.
What I'm doing currently is:
- cloning https://github.com/solana-labs/solana-program-library
cd solana-program library/account-compression && anchor build- adding
--bpf-program noopb9bkMVfRPU8AsbpTUg8AQkHtKwMYZiFUjNRtMmV ../../solana-program-library/account-compression/target/deploy/spl_noop.soto my validator command
Would you be fine with describing it here?
OTOH, I could try --clone noopb9bkMVfRPU8AsbpTUg8AQkHtKwMYZiFUjNRtMmV to copy the noop program from devnet, but not sure if it's going to work 100% for our tests.
There was a problem hiding this comment.
--clone didn't work for me the last time I tried
There was a problem hiding this comment.
maybe we should add solana_sbf_rust_noop.so to the our repo
I think that would be the easiest
There was a problem hiding this comment.
We don't have to use a cloned Solana repo anymore, the newest testnet versions of Solana CLI tools are working fine.
Have you tried the most recent solana cli version with --bpf-programs that gave me an error,
the Solana devs already closed the issue but I am not sure it is fixed and if it is whether it is in the current release already
There was a problem hiding this comment.
OK, I tested now and:
--clonedoesn't work for me--bpf-program --bpf-program noopb9bkMVfRPU8AsbpTUg8AQkHtKwMYZiFUjNRtMmV ../../solana-program-library/account-compression/target/deploy/spl_noop.soworks great. I tried both with master andaccount-compression-v0.1.8tag of solana-program-library.
maybe we should add solana_sbf_rust_noop.so to the our repo
What about adding solana-program-library as a submodule? It would be easier to bump versions and the process would be more transparent to everyone - more than people pushing .so files manually. ;)
There was a problem hiding this comment.
if adding it as a submodule should add a script that builds the noop pogram?
There was a problem hiding this comment.
Yeah, I was thinking about:
- adding a submodule
- adding a script for building the noop program
- calling it from the current runTest.sh scripts
vadorovsky
changed the title
| --bpf-program J1RRetZ4ujphU75LP8RadjXMf3sA12yC2R44CF7PmU7i ../light-system-programs/target/deploy/verifier_program_zero.so \ | ||
| --bpf-program JA5cjkRJ1euVi9xLWsCJVzsRzEkT8vcC4rqw9sVAo5d6 ../light-system-programs/target/deploy/merkle_tree_program.so \ | ||
| --bpf-program GFDwN8PXuKZG2d2JLxRhbggXYe9eQHoGYoYK5K3G5tV8 ../light-system-programs/target/deploy/verifier_program_two.so \ | ||
| --bpf-program Fg6PaFpoGXkYsidMpWTK6W2BeZ7FEfcYkg476zPFsLnS ../market-place-verifier/target/deploy/market_place_verifier.so |
There was a problem hiding this comment.
@ananas-block This is different from what we have in mock-app-verifier/runTest.sh. Here we are using market_place_verifier.so, in the script we are using mock_verifier.so instead. Which one should we use?
There was a problem hiding this comment.
it should be mock_verifier.so
|
Irrelevant when #32 gets in |
2 participants
We don't have to use a cloned Solana repo anymore, the newest testnet versions of Solana CLI tools are working fine.