Glade Tooltable widget destroys tooltable in a particular case

[hansu]

When using locale settings for e.g. Germany, so having a "," as decimal point, the tool table shows the correct decimal point after starting.
But after loading an (empty) G-code file and reloading the tool table, the decimal point changes to a dot:

temp-2024-04-19_15.42.17.mp4

This can lead to loss of the complete tool table in the following (quite common) case:

1. Load a G-code file
2. Add the missing tool
3. Apply the changes ... boom! all tools are gone!

temp-2024-04-19_15.44.31.mp4

Version: latest from 2.9 branch.

Traceback (most recent call last):
  File "/home/cnc/linuxcnc/linuxcnc-2.9/bin/gmoccapy", line 4947, in on_btn_apply_tool_changes_clicked
    self.widgets.tooledit1.save(None)
  File "/home/cnc/linuxcnc/linuxcnc-2.9/lib/python/gladevcp/tooledit_widget.py", line 348, in save
    line = line + "%s%s "%(KEYWORDS[num], locale.atof(test))
                                          ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/locale.py", line 338, in atof
    return func(delocalize(string))
           ^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: could not convert string to float: '0,0000'
 (gmoccapy:62)
Tool file was modified since it was last read
/usr/lib/python3/dist-packages/gi/overrides/GObject.py:493: Warning: ../../../gobject/gsignal.c:2772: instance '0x460ff90' has no handler with id '113342181'
  return func(*args, **kwargs)

[zz912]

I can confirm this behavior. Any G-code file can be used for recall, not just an empty G-code file.

In place for tool information is used as a decimal point and a dot. It is also in the Czech localization.

It looks wierd.

[hansu]

Possible workarounds are:

1. Click on reload tool table before adding a tool

2. Use reload tool on start in the settings:

[hansu]

The problem does not appear on Debian Bullseye / Python 3.9.2

[hansu]

I was able to encircle the error. The problem is that the locale setting gets destroyed when showing the main box.

Good to see with these debug prints:
hansu@0fe0482

Output:

--- INIT:352, locale:  ('de_DE', 'UTF-8')
--- INIT:356, locale:  (None, None)

If I set the locale again after this with
locale.setlocale(locale.LC_ALL, '')
all works fine.
But this does't sound like a clean solution.

@c-morley any idea on this?

[hansu]

Just for information to avoid double work - my working branch: https://github.com/hansu/linuxcnc/tree/2966-gmoccapy-destroys-tooltable

[zz912]

Hello,

I tested your branche.
Backup file is working. It is fine.
Would it be possible to add "create backup file" to the official 2.9 branch already? Although this is not a solution to the problem, it would help a lot. Setting corrections for 10 instruments and then losing them is annoying.

BUT, I have different results from your test:
branche hansu/2966-gmoccapy-destroys-tooltable
--- INIT:352, locale: ('cs_CZ', 'UTF-8')
--- INIT:356, locale: ('cs_CZ', 'UTF-8')

branche linuxcnc/master (I added "print ...." commands to source code)
--- INIT:352, locale: ('cs_CZ', 'UTF-8')
--- INIT:356, locale: ('cs_CZ', 'UTF-8')

I use RIP installation. Debian 12. Physical PC

zdenek@cnc:~$ uname -a
Linux cnc 6.1.0-22-rt-amd64 #1 SMP PREEMPT_RT Debian 6.1.94-1 (2024-06-21) x86_64 GNU/Linux

[zz912]

I tried change localization and result is same:
--- INIT:352, locale: ('de_DE', 'UTF-8')
--- INIT:356, locale: ('de_DE', 'UTF-8')

commands for set localization:
localectl set-locale LANG=cs_CZ.UTF-8

localectl set-locale LANG=de_DE.UTF-8

localectl set-locale LANG=en_US.UTF-8

localectl

source: https://www.server-world.info/en/note?os=Debian_12&p=locale

[hansu]

Propably the locale setting get lost at another position on your system if you still encounter the tooltable bug.
You can set the debug print on other lines to figure out when it happens. Maybe begin with placing it at the end of the gmoccapy init function.

[zz912]

I don't understand why you are looking for bugs in the init function.

I added the command "print ..." twice to the on_btn_new_clicked function:

gmoccapy.py:

    # make a new file
    def on_btn_new_clicked(self, widget, data=None):
        tempfilename = os.path.join(_TEMPDIR, "temp.ngc")
        content = self.get_ini_info.get_RS274_start_code()
        content += "\n\n\n\nM2"
        print("on_btn_new_clicked-1", locale.getlocale(locale.LC_NUMERIC))
        gcodefile = open(tempfilename, "w")
        gcodefile.write(content)
        gcodefile.close()
        if self.widgets.lbl_program.get_label() == tempfilename:
            self.widgets.hal_action_reload.emit("activate")
        else:
            self.widgets.hal_action_open.load_file(tempfilename)
            # self.command.program_open(tempfilename)
        self.widgets.gcode_view.grab_focus()
        self.widgets.btn_save.set_sensitive(False)
        print("on_btn_new_clicked-2", locale.getlocale(locale.LC_NUMERIC))

To execute this function, you must press this button:

Result after the first press:
on_btn_new_clicked-1 ('cs_CZ', 'UTF-8')
on_btn_new_clicked-2 ('cs_CZ', 'UTF-8')

Result after the second press:
on_btn_new_clicked-1 (None, None)
on_btn_new_clicked-2 (None, None)

Something delocalizate it, but I don't know what happens after loading some *.ngc file. Could it be a gremlin? I couldn't get Gmoccapy to run without Gremlin.