Make log level for VCPs configurable #3126

hansu · 2024-09-19T09:41:13Z

Currently in gmocappy you get a lot of warnings from the logger of the QT_ISTAT instances which are not relevant for gmoccapy.
The more VCPs you are using the more (non-relevant) log messages you get, which makes it hard to focus on the real debug messages you want to see.
So I looked for a way to suppress these warnings.

I added an INI setting which can control this:
VCP_LOGLEVEL = ERROR

I am open for other suggestions...

Furthermore I set the default level of the logger itself to WARNING like the default value of all the others which are using the logger.

In INI file with [DISPLAY] VCP_LOGLEVEL = <log_level> With <log_level> = one of DEBUG, INFO, WARNING, ERROR, CRITICAL

To reduce the number of default log outputs and to be consistent with the other instances of the logger.

c-morley · 2024-09-19T17:06:10Z

I don't think we need to add another ini log level setting. Gmccapy and glavevcp should set the level with there own debug switches.
I though gmoccspy already did this.

Gladevcp and Qtvcp should not complain about INI settings if no INI has been given.
This probably needs some work.

Maybe we could get our heads together and decide on common ini requirements rather then each GUI having it's own similar one.
We could even make a common GUI INI parser like GStat is fir status messages.

hansu · 2024-09-19T20:11:36Z

Thanks for your feedback.

Gmccapy and glavevcp should set the level with there own debug switches.
I though gmoccspy already did this.

Yes without DISPLAY = gmoccapy -q I would get even more log messages.

Gladevcp and Qtvcp should not complain about INI settings if no INI has been given.

I currently get this mass of log messages because I have some VCPs integrated:
And I get all warnings repeated for each VCP. That's a bit annoying.

[GladeVCP][INFO]  Logging to: /home/cnc/gladevcp.log (logger.py:106)
[GladeVCP][INFO]  Logging to: /home/cnc/gladevcp.log (logger.py:106)
[GladeVCP][INFO]  Logging to: /home/cnc/gladevcp.log (logger.py:106)
[GladeVCP][INFO]  Logging to: /home/cnc/gladevcp.log (logger.py:106)
....
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No DEFAULT_SPINDLE_0_SPEED Entry in DISPLAY, Using: 200 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MIN_SPINDLE_0_SPEED Entry in DISPLAY, Using: 100 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MAX_SPINDLE_0_SPEED Entry in DISPLAY, Using: 2500 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MAX_SPINDLE_0_OVERRIDE Entry in DISPLAY, Using: 1 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MIN_SPINDLE_0_OVERRIDE Entry in DISPLAY, Using: 0.5 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No DEFAULT_SPINDLE_0_SPEED Entry in DISPLAY, Using: 200 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MIN_SPINDLE_0_SPEED Entry in DISPLAY, Using: 100 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MAX_SPINDLE_0_SPEED Entry in DISPLAY, Using: 2500 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MAX_SPINDLE_0_OVERRIDE Entry in DISPLAY, Using: 1 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MIN_SPINDLE_0_OVERRIDE Entry in DISPLAY, Using: 0.5 (qt_istat.py:532)
[GladeVCP.GMOCCAPY.GETINIINFO][INFO]  Preference file path: /home/cnc/linuxcnc/configs/Sieg-X1/Sieg-X1.pref (getiniinfo.py:74)
144703491
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No DEFAULT_SPINDLE_0_SPEED Entry in DISPLAY, Using: 200 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MIN_SPINDLE_0_SPEED Entry in DISPLAY, Using: 100 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MAX_SPINDLE_0_SPEED Entry in DISPLAY, Using: 2500 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MAX_SPINDLE_0_OVERRIDE Entry in DISPLAY, Using: 1 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MIN_SPINDLE_0_OVERRIDE Entry in DISPLAY, Using: 0.5 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No DEFAULT_SPINDLE_0_SPEED Entry in DISPLAY, Using: 200 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MIN_SPINDLE_0_SPEED Entry in DISPLAY, Using: 100 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MAX_SPINDLE_0_SPEED Entry in DISPLAY, Using: 2500 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MAX_SPINDLE_0_OVERRIDE Entry in DISPLAY, Using: 1 (qt_istat.py:532)
[GladeVCP.QTVCP.QT_ISTAT][WARNING]  INI Parsing Error, No MIN_SPINDLE_0_OVERRIDE Entry in DISPLAY, Using: 0.5 (qt_istat.py:532)

Maybe we could get our heads together and decide on common ini requirements rather then each GUI having it's own similar one.
We could even make a common GUI INI parser like GStat is fir status messages.

Sounds good 👍

c-morley · 2024-09-19T20:44:39Z

Remind me .. integrated vcps require a separate gladevcp Instance (embedded) or does gmoccapy integrate the gladevcp directly into gmoccapy's instance?
What I'm getting at is if there are separate gladevcp loading commands that is where the logging level should be set.
In my opinion warnings should not show if in quiet mode and I think that us how it works now. Can you add -q and remove the warnings?

hansu · 2024-09-21T19:13:08Z

Remind me .. integrated vcps require a separate gladevcp Instance (embedded) or does gmoccapy integrate the gladevcp directly into gmoccapy's instance?

One gladevcp instance is embedded in gmoccapy - you get that even without VCPs

Can you add -q and remove the warnings?

No, gladevcp doesn't have that option. Only qtvcp has this.
But If I add this to gladevcp - it doesn't change anything because the log messages come from qt_istat.py.
And I don't know how resp. why this file is involved when using gladevcp without QT ...

c-morley · 2024-09-21T21:49:30Z

try this:
https://github.com/LinuxCNC/linuxcnc/tree/gmoccapy_gladevco_logging_fix

andypugh · 2024-09-21T22:44:37Z

This level of output does seem excessive, but on the other hand it's potentially useful info, hinting that the integrator really ought to have put some data in the INI.

I am guessing we don't have an "INFO" level? "WARNING" seems a little too serious for these.

hansu · 2024-09-22T12:37:01Z

[Andy]

I am guessing we don't have an "INFO" level? "WARNING" seems a little too serious for these.

Yes we have but I think WARNING is ok as we also have ERROR and CRITICAL above.

[Chris]

try this:
https://github.com/LinuxCNC/linuxcnc/tree/gmoccapy_gladevco_logging_fix

I think it's a good solution together with #2335

Expect that I still get those lines, one for every loaded VCP:

[GladeVCP][INFO]  Logging to: /home/cnc/gladevcp.log (logger.py:106)
[GladeVCP][INFO]  Logging to: /home/cnc/gladevcp.log (logger.py:106)
[GladeVCP][INFO]  Logging to: /home/cnc/gladevcp.log (logger.py:106)
[GladeVCP][INFO]  Logging to: /home/cnc/gladevcp.log (logger.py:106)

hansu · 2024-09-22T12:55:54Z

Maybe we could get our heads together and decide on common ini requirements rather then each GUI having it's own similar one.
We could even make a common GUI INI parser like GStat is fir status messages.

We should make _IStat more universal. See my comments in #2335 (comment)

hansu · 2024-09-23T07:35:47Z

try this: https://github.com/LinuxCNC/linuxcnc/tree/gmoccapy_gladevco_logging_fix

Can you push that to master or make a pull request?

andypugh · 2024-09-23T19:44:59Z

Where are we with this? Is the suggestion in the link above something to merge instead of this PR, or in addition to this PR?

hansu · 2024-09-23T20:34:54Z

Where are we with this? Is the suggestion in the link above something to merge instead of this PR, or in addition to this PR?

That commit resolves my issue to 90%, so yes instead

c-morley · 2024-09-24T00:08:46Z

try this: https://github.com/LinuxCNC/linuxcnc/tree/gmoccapy_gladevco_logging_fix

Can you push that to master or make a pull request?

Pushed this to master now.

As for the multiple:
[GladeVCP][INFO] Logging to: /home/chris/gladevcp.log (logger.py:106)

First do you think it would be better to log to different files (maybe by adding the gladevcp object name) for each gladevcp instance?
or
Do we even need to log to a file at all?

hansu · 2024-09-24T06:12:09Z

Do we even need to log to a file at all?

Not really as we usually don't have a logger in the VCPs.

For me the log file only contains

GladeVCP - INFO Logging to: /home/cnc/gladevcp.log

So I think it's safe to disable/remove logging for that.

hansu added 2 commits September 19, 2024 11:30

qt_istat: make log level configurable

e200b7a

In INI file with [DISPLAY] VCP_LOGLEVEL = <log_level> With <log_level> = one of DEBUG, INFO, WARNING, ERROR, CRITICAL

gladevcp: change default loglevel to WARNING

082427a

To reduce the number of default log outputs and to be consistent with the other instances of the logger.

hansu assigned c-morley Sep 19, 2024

hansu added the affects gmoccapy label Sep 19, 2024

hansu closed this Sep 27, 2024

hansu deleted the vcp-loglevel branch September 27, 2024 21:41

hansu mentioned this pull request Jun 30, 2025

Gmoccapy - change spindle => spindle_0 in *.ini files #3488

Draft

Make log level for VCPs configurable #3126

Make log level for VCPs configurable #3126

Uh oh!

Conversation

hansu commented Sep 19, 2024

Uh oh!

c-morley commented Sep 19, 2024

Uh oh!

hansu commented Sep 19, 2024

Uh oh!

c-morley commented Sep 19, 2024

Uh oh!

hansu commented Sep 21, 2024

Uh oh!

c-morley commented Sep 21, 2024

Uh oh!

andypugh commented Sep 21, 2024

Uh oh!

hansu commented Sep 22, 2024

Uh oh!

hansu commented Sep 22, 2024

Uh oh!

hansu commented Sep 23, 2024

Uh oh!

andypugh commented Sep 23, 2024

Uh oh!

hansu commented Sep 23, 2024

Uh oh!

c-morley commented Sep 24, 2024

Uh oh!

hansu commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hansu commented Sep 24, 2024 •

edited

Loading