Gmoccapy: improvements to the offsetpage widget #3457
Conversation
Sigma1912
commented
May 28, 2025
Sigma1912
commented
- Remove rows 'G5x' and 'Rot'
- Add rows for G28 and G30 offsets
- Add column 'R' for rotation R value in offsets 'G54' .. 'G59.3'
- Rename column 'name' to 'Comment'
|
It seems that this widget might be used by GUIs other than Gmoccapy. I have not been able to find any though and have thus only tested this in Gmoccapy. Looks like this:
|
Sigma1912
force-pushed
the
Gmoccapy_modify-offsetpage-widget
branch
2 times, most recently
from
054afd1 to
9053e8b
Compare
|
Really great, that you! But I would suggest to use 'Rot' for rotation instead of 'R' to make sure that it's not a linear offset. In which case was 'G5x' displayed? In the above mentioned Issue there is no 'G5x'. |
Sure, I'll push a fix.
To be honest I'm not exactly sure where in the code the 'g54x' row was hidden but I guess it was realized that with highlighting the active offset the 'g5x' row was just duplicate information. If this is not used by any other GUI, I'd really love to get rid of all the extra code that is not used in Gmoccapy. |
Sigma1912
force-pushed
the
Gmoccapy_modify-offsetpage-widget
branch
from
9053e8b to
73b233a
Compare
Sigma1912
force-pushed
the
Gmoccapy_modify-offsetpage-widget
branch
from
73b233a to
31c8ebb
Compare
|
Looks good, only one question:
Why? Intentional or not possible? |
- Remove rows 'G5x' and 'Rot' - Add rows for G28 and G30 offsets - Add column 'Rot' for rotation R value in offsets 'G54' .. 'G59.3' - Rename column 'name' to 'Comment' - Editing a 'Tool' value will call 'G43.1 [x,y,z,a,b,c,u,v,w] [value]' - Editing a 'G28' value will write to the appropriate parameter[5161..5169] - Editing a 'G30' value will write to the appropriate parameter[5181..5189]
Sigma1912
force-pushed
the
Gmoccapy_modify-offsetpage-widget
branch
from
31c8ebb to
9b0fa3d
Compare
|
Thanks for testing, I have expanded editing to all rows:
|
Sorry I was a bit unclear, I thought about their comment column, but very cool to have them editable! Only for the tool I am not sure if this could cause some trouble. Of course it is very handy, but imagine if you change the value there and don't change it in the tool table and then change to another tool and then back to this tool... The default comments for G28 and G30 are now displayed as '0'. Can we have them just empty or name them G28 and G30? (I know a bit duplicated, but consistent to the rest) And when I look at the tool row - do you think it is possible to write there the comment from the tool table? PS: It is fine and in most cases also better to have multiple commits in a pull request. It allows me for example to trace your additions and makes is easier to fetch your additions. Fetch updates from a force-pushed HEAD is not so handy. But anyway, already a good improvement! |
…to system name instead of zero
The offset page should give an overview of all applied offsets and also a way to quickly change them.
Following the reasons above I would rather put a note like 'NOT saved to tooltable!' in the comment of the 'Tool' row. The comment from the tool table is already displayed in the 'Tool Information' frame below the offset page.
|
Yes of course
No I don't want to change the tool table from here as well. Yeah maybe it's better to not have the comment from the tool table there to not give the impression that this corresponds always to the tool table. |
|
I've pushed the change you can easily change the default comment for the 'Tool' row. |
Sigma1912
force-pushed
the
Gmoccapy_modify-offsetpage-widget
branch
from
9f0891d to
1f22f1e
Compare
|
👍 |
2 participants
