refactor: use GeneralDialog in character stats table #6963
Merged
+29
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
approved these changes
Jan 10, 2026
ElectricalBoy
force-pushed
the
general-dialog
branch
from
09fc7d5 to
6c8b7de
Compare
ElectricalBoy
force-pushed
the
characterstats-use-popup
branch
from
ed4201e to
3bc4cf8
Compare
hjpalpha
approved these changes
Jan 19, 2026
hjpalpha
approved these changes
Jan 20, 2026
Eetwalt
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #6962
This PR:
How did you test this change?
sandbox in LoL