Skip to content

Chrome: supress dialog box and support more executables #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Symbolics merged 2 commits into from
Oct 20, 2022
Merged

Chrome: supress dialog box and support more executables #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d02c11b
Suppress first time startup dialog box and reuse the same data directory
tobyWorland Oct 18, 2022
752b35a
On Linux, try a few potential chrome executables until one is found
tobyWorland Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions src/plot/browser.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,28 @@
;;; specific to each browser that is selected in the arguments to
;;; uiop:launch-program.

;;;
;;; Chrome on Linux
;;;

(defun find-chrome-executable-linux ()
"Find Chrome's executable for Linux distributions"
;; Linux distributions unfortunately do not all use the same name for chrome,
;; or there may only be chromium installed.
;; Partial list of executables: https://unix.stackexchange.com/questions/436835/universal-path-for-chrome-on-nix-systems
(find-if (lambda (potential-executable)
(ignore-errors
(zerop (nth-value 2 (uiop:run-program (list potential-executable "--version"))))))
(list "google-chrome" "chrome" "google-chrome-stable" "chromium" "chromium-browser")))

;;;
;;; Functions and data for all browsers
;;;

(defparameter *browser-commands*
(list (cons :chrome #+win32 "C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe"
#+(or macos darwin) "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"
#+linux "chrome") ;See https://unix.stackexchange.com/questions/436835/universal-path-for-chrome-on-nix-systems
#+linux (find-chrome-executable-linux))
(cons :firefox #+win32 "C:\\Program Files (x86)\\Mozilla Firefox\\firefox.exe"
#+(or macos darwin) "/Applications/Firefox.app/Contents/MacOS/firefox"
#+linux "firefox")
Expand Down Expand Up @@ -55,10 +70,14 @@
"Encode command line options for Chrome"
;; We want to add a --user-data-directory so that --windows-size is honoured
;; --app, if present, will have been set by the caller
;; We also want --no-default-browser-check and --no-first-run to suppress
;; a dialog box shown on startup when an empty data directory is picked.
;; See note at top of file about proper way to set window attributesc
(let ((chrome-options (push (cons "user-data-dir"
(merge-pathnames (format nil "chrome-data-~A" (princ-to-string (gensym)))
(translate-logical-pathname #P"PLOT:TEMP;")))
(let ((chrome-options (append (list (cons "user-data-dir"
(merge-pathnames "chrome-data"
(translate-logical-pathname #P"PLOT:TEMP;")))
(cons "no-default-browser-check" 1)
(cons "no-first-run" 1))
options)))
(encode-application-options chrome-options "--~A=~A")))

Expand Down