CM-1037: Pass TTD cookie through prebid endpoint by wi101 · Pull Request #31 · LiveIntent/Prebid.js

wi101 · 2023-12-14T09:24:33Z

CM-1037

3link · 2023-12-14T14:44:17Z

modules/liveIntentIdSystem.js

That should change to thetradedesk . We can ask @deepthivenkat if the name used to expose the id in Prebid should be thetradedesk too.

I changed it to thetradedesk

would it be possible to make the provider as the name of the domain for which the id is going to be passed? Something like:
let domain = window.location.hostname;
and then use source: domain

It would be possible, but would require more work which could only be done beginning of the next year. Also, we would only be able to expose the current domain as is - e.g. if it is abc.nyt.com, it will be abc.nyt.com and not nyt.com as we would not know what is the top level domain to split by. There is also risk that it might not be accepted by Prebid.

Can't they grab the domain from the request?

I wonder how could we decide which provider domain to use 🤔
And do we want to change the source or the ext.provider?
cc @deepthivenkat

We can expose current domain as such and not origin apex domain. That is fine. Confirmed with prebid that changing provider to originating domain is ok. The thought process is - the feature is to support open path and the publisher who wants to directly integrate with TD is the one considered as provider for the id

We should be changing ext.provider. Apologies for the confusion Wiem! I should have mentioned ext.provider in the example.

Thank you @deepthivenkat for the clarification

3link · 2024-01-02T09:03:28Z

modules/liveIntentIdSystem.js

      }

+      if (value.thetradedesk) {
+        result.thetradedesk = { 'id': value.thetradedesk, ext: { provider: getRefererInfo().domain || LI_PROVIDER_DOMAIN } }


Can we test that without injecting the value?

without mocking the refererInfo, the domain value would be: localhost:9876
I am trying to find a way to change the page&location in the test to have a proper domain.

as discussed, will test it in a page.

tested it (in the lab account: https://vdreiling-lab-test.s3.amazonaws.com/prebidTest/prebid_test_page.html) with a static thetradedesk ID and the provider was correct : "vdreiling-lab-test.s3.amazonaws.com"

Agree. This is the correct provider :)

wi101 · 2024-02-20T09:27:43Z

opened a PR in prebid repo

* KRKPD-1083: Refactor and expand testing (#31) * Refactor the Kargo adapter testing to be more comprehensive and include testing of invalid inputs * Fix the window size test to pull data from the browser instead of hardcoded values * Remove a duplicate test * unhook triggerPixel after tests * fixes circleci failure * Update the localStorage non-functional test In FireFox, having localStorage.getItem throw an error isn't working so the test was updated to not have a valid localStorage value to pass on FireFox. * Restore the bidderSettings following testing --------- Co-authored-by: William Klausmeyer <klawil@users.noreply.github.com> Co-authored-by: “Nick <“nick.llerandi”@kargo.com> Co-authored-by: William Klausmeyer <willyk95@gmail.com>

…rameters (prebid#13122) * V 0 29 (#31) * AGT-403: Add adType parameter to payload in report * AGT-403: Test for partner report, adType parameter * AGT-403: Test refactoring * AGT-403: Documentation updated * IntentIq Analytics Module: adUnitCode or placemetId to report (#9) * AGT-446: adUnitCode or placemetId to report * AGT-446: Description of changes, example * AGT-446: Fix documentation * AGT-446: Changes after review * Agt 409 full url in prebid modules (#8) * add sync * update full url * set url param * fix comment * fix issue fix sync mode * update url * update full url * add test * move browser_blacklist (#10) * add is optedOut (#11) * update date in FPD after sync (#12) * update sync logic for new user (#13) * fix unit tests * change version name * IntentIq ID: Support sourceMetaData and sourceMetaDataExternal (#17) * AGT-453: Support sourceMetaData * AGT-453: sourceMetaDataExternal * AGT-453: Documentation * AGT-453: Changes after review * AGT-453: Fix doc * Fix doc * AGT-453: Fix test * update test * update endpoint (#16) * update endpoint * update test * add tests * update test * fix conflict * fix conflict * add test for reportingServerAddress * add test for reportingServerAddress * AGT-498: support report method parameter (#22) * AGT-498: reportMethod * AGT-498: Tests and refactoring * AGT-498: method refactoring * AGT-498: get method refactoring * AGT-498: reportMethod parameter description (#23) * AGT-498: reportMethod * AGT-498: Tests and refactoring * AGT-498: method refactoring * AGT-498: get method refactoring * AGT-498: Documentation * Agt 452 server call counters (#18) * add counters * add unit tests and fixes * counters additions * clear counters when a request is made --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * add siloEnabled feature (#19) * add siloEnabled feature * add siloEnabled feature to analytics adapter * add unit tests for siloEnabled feature * add siloenabled to docs --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * fix unit test issues * AGT-455: Source parameter in requests (#28) * AGT-508: Spd parameter (#29) * AGT-508: Spd parameter * AGT-508: Move appendSpd to utils * AGT-499: Support partnerClientIdType and partnerClientId (#30) * AGT-499: partnerClientId and partnerClientIdType in requests * AGT-499: Clean comment * AGT-499: Refactoring * add groupchanged parameter (#25) * add groupchanged parameter * fix md file issue * add groupChanged example in docs * remove group from example * add unit tests and fix groupChanged issue --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com> * Agt 501 support additional params (#24) * additionalParams feature init * additional params add features * additionalparams fix analytics adapter * add unit tests for additionalParams * fix currentBrowser issue --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com> * fix linter error --------- Co-authored-by: dmytro-po <dmytro.po@intentiq.com> Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com> Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com> Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com> Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * fix unit tests (#32) Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * Agt 547 vr bug for module (#33) * save progress * fix calling server * add "dbsaved" parameter * add tests * AGT-552: Additional query params (#34) * AGT-552: Additional query params * update documentation --------- Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com> * Fix unit test for specific browser * fix spelling --------- Co-authored-by: Eyvaz <62054743+eyvazahmadzada@users.noreply.github.com> Co-authored-by: dmytro-po <dmytro.po@intentiq.com> Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com> Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

add adserver

6bffa80

wi101 self-assigned this Dec 14, 2023

SuperIzya approved these changes Dec 14, 2023

View reviewed changes

3link reviewed Dec 14, 2023

View reviewed changes

change adserver to thetradedesk

14862dd

wi101 requested a review from 3link December 14, 2023 16:15

wi101 added 6 commits December 15, 2023 11:00

add test case in liveIntentIdMinimalSystem_spec

560010b

Merge branch 'master' into cm-1037

af7301e

update lc version

599c506

Merge branch 'master' into cm-1037

7ab0963

use domain as ext provider

b24c7c9

refactor

1aef559

peixunzhang approved these changes Dec 21, 2023

View reviewed changes

3link reviewed Jan 2, 2024

View reviewed changes

wi101 added 5 commits January 3, 2024 09:19

Merge branch 'master' into cm-1037

5d2d2e0

refactoring and rollback lc version

7146493

Merge branch 'master' into cm-1037

ada8d7f

Merge branch 'master' into cm-1037

ef677e8

Merge branch 'master' into cm-1037

997aaeb

wi101 mentioned this pull request Feb 19, 2024

Add thetradedesk id LiveIntent/prebid.github.io#23

Closed

wi101 closed this Feb 20, 2024

wi101 deleted the cm-1037 branch February 20, 2024 09:27

wi101 mentioned this pull request Feb 28, 2024

Refactor the TTD usage and add test #40

Closed

Conversation

wi101 commented Dec 14, 2023 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3link Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wi101 Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wi101 commented Feb 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

wi101 commented Dec 14, 2023 •

edited by atlassian bot

Loading

3link Dec 19, 2023 •

edited

Loading

wi101 Jan 5, 2024 •

edited

Loading