Conversation
The old Edge doesn't have the ancestorOrigins implemented.
…window.top" is defined.
|
@melgenek this looks cool! Are we extracting the ajax to have the same signature as prebid in a separate PR? |
|
@jankoulaga yes. I'll create a separate pr for the extraction. I want to release a dedicated version of lc2 builder with the changes from this pr to keep the changes in each version granular. |
| */ | ||
| function _send (state) { | ||
| function _sendAjax (state) { | ||
| _sendState(state, 'j', uri => { |
There was a problem hiding this comment.
DOn't we need the onload here as well?
There was a problem hiding this comment.
it was one line below. I moved the bakers' calls into a separate function to make the code a bit more clear. And now the ajax callback calls the "onload" and "callBakers" https://github.com/LiveIntent/live-connect/pull/25/files#diff-51925b852a9fa34aa4d658fa7cd30c4dR22-R23
gipeshka
left a comment
gipeshka
left a comment
There was a problem hiding this comment.
Does this PR contain parts of referer fix?
|
@gipeshka there was a pr into a branch that is not a master when I merged it the changes were shown for the referrer as well. |
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 93.84% 93.97% +0.13%
==========================================
Files 28 29 +1
Lines 731 747 +16
==========================================
+ Hits 686 702 +16
Misses 45 45
Continue to review full report at Codecov.
|
|
@gipeshka can you check this please? |
4 participants
This pr still uses the embedded ajax and pixel implementations. I'll create a separate pr to make them pluggable.
Related prs: