This repository was archived by the owner on Jan 27, 2025. It is now read-only.
Minor improvements, fix wrapper name.#4
Merged
jankoulaga merged 2 commits intomasterfrom Mar 13, 2020
Merged
Conversation
…acy pixel usage in a single manager, fixed wrapper name to be sent correctly.
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
+ Coverage 93.67% 93.76% +0.08%
==========================================
Files 28 28
Lines 712 706 -6
==========================================
- Hits 667 662 -5
+ Misses 45 44 -1
Continue to review full report at Codecov.
|
melgenek
approved these changes
Mar 13, 2020
jankoulaga
added a commit
to LiveIntent/Prebid.js
that referenced
this pull request
Mar 13, 2020
…me was sent with an incorrect param name. PR for this change : LiveIntent/live-connect#4 The effects can be seen in the specs, where the incorrect `wrpn` sent as a pixel is now `wpn`
harpere
pushed a commit
to prebid/Prebid.js
that referenced
this pull request
Mar 18, 2020
* Use LiveIntent's liveconnect. Fire an event each time id is resolved. * Rename variables. Simplify imports. * Example page for LiveIntent Id module * Add application id param * Expose all possible configuration options for LiveConnect * Bumping version of live-connect-js to support: - storage manipulation provided by PBJS - ajax calls directly from PBJS * Removed spec whitespace. * Removed spec whitespace. * Removed spec for cookies * Reshuffled variables. * Re-added `findSimilarCookies` spec for further checks * Added a comment on the function to find all cookies that match a certain name. * Fixing setCookie not to include the expires as undefined. * Fixing setCookie not to include the expires as undefined. * Updated live-connect-js to 1.1.1, fixing the bug where the wrapper name was sent with an incorrect param name. PR for this change : LiveIntent/live-connect#4 The effects can be seen in the specs, where the incorrect `wrpn` sent as a pixel is now `wpn` * Removed whitespace. Co-authored-by: janko <janko.ulaga@gmail.com>
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
* Use LiveIntent's liveconnect. Fire an event each time id is resolved. * Rename variables. Simplify imports. * Example page for LiveIntent Id module * Add application id param * Expose all possible configuration options for LiveConnect * Bumping version of live-connect-js to support: - storage manipulation provided by PBJS - ajax calls directly from PBJS * Removed spec whitespace. * Removed spec whitespace. * Removed spec for cookies * Reshuffled variables. * Re-added `findSimilarCookies` spec for further checks * Added a comment on the function to find all cookies that match a certain name. * Fixing setCookie not to include the expires as undefined. * Fixing setCookie not to include the expires as undefined. * Updated live-connect-js to 1.1.1, fixing the bug where the wrapper name was sent with an incorrect param name. PR for this change : LiveIntent/live-connect#4 The effects can be seen in the specs, where the incorrect `wrpn` sent as a pixel is now `wpn` * Removed whitespace. Co-authored-by: janko <janko.ulaga@gmail.com>
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* Use LiveIntent's liveconnect. Fire an event each time id is resolved. * Rename variables. Simplify imports. * Example page for LiveIntent Id module * Add application id param * Expose all possible configuration options for LiveConnect * Bumping version of live-connect-js to support: - storage manipulation provided by PBJS - ajax calls directly from PBJS * Removed spec whitespace. * Removed spec whitespace. * Removed spec for cookies * Reshuffled variables. * Re-added `findSimilarCookies` spec for further checks * Added a comment on the function to find all cookies that match a certain name. * Fixing setCookie not to include the expires as undefined. * Fixing setCookie not to include the expires as undefined. * Updated live-connect-js to 1.1.1, fixing the bug where the wrapper name was sent with an incorrect param name. PR for this change : LiveIntent/live-connect#4 The effects can be seen in the specs, where the incorrect `wrpn` sent as a pixel is now `wpn` * Removed whitespace. Co-authored-by: janko <janko.ulaga@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated vulnerabilities in deps, removed redundant code, isolated legacy pixel usage in a single manager, fixed wrapper name to be sent correctly.