Skip to content

Conversation

@r2dev2
Copy link
Member

@r2dev2 r2dev2 commented Mar 12, 2023

Adds support for MV3 in Firefox. Some things to note:

Problems

  1. ff does not support service workers in their mv3 "support"
  2. ff does not support extension to content script channels in their mv3 "support"

Solutions

  1. use bg script for ff and service workers for chrome
    • implies that chrome and ff need completely different manifests (one is not superset of other)
    • introduce yarn dev:firefox and yarn dev:chrome and make yarn start alias for yarn dev:chrome
  2. proxy extension to content script messages through background script for ff
    • unsure how long bg script for ff persists, I think it should stay up as long as chat is active?
    • should give to ff beta testers to make sure it actually works over long intervals

@r2dev2 r2dev2 requested review from ChrRubin and KentoNishi March 12, 2023 22:16
Copy link
Member

@KentoNishi KentoNishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you swap yarn build to be chrome by default and add a yarn build:firefox instead?

@r2dev2
Copy link
Member Author

r2dev2 commented Mar 12, 2023

can you swap yarn build to be chrome by default and add a yarn build:firefox instead?

Done in aa99119

@r2dev2 r2dev2 requested a review from KentoNishi March 12, 2023 22:43
Copy link
Member

@KentoNishi KentoNishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u forgot to update the readme

@r2dev2
Copy link
Member Author

r2dev2 commented Mar 13, 2023

u forgot to update the readme

a7eccb8

@r2dev2 r2dev2 requested a review from KentoNishi March 13, 2023 18:36
@r2dev2 r2dev2 merged commit 899dc73 into mv3 Mar 21, 2023
@r2dev2 r2dev2 deleted the ff-mv3 branch March 21, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants