Nightly Change Log Improvements#1076
Closed
Nonary wants to merge 13 commits intoLizardByte:nightlyfrom
Closed
Conversation
…ve indexes I guess this was someone who was used to too much Python :) Also added an additional check to remove stable releases that aren't a new version
This commit refactors the stableBuildAvailable() and nightlyBuildAvailable() computed properties to improve code clarity. The buildVersionIsStable() method has been renamed to isStableBuild() for better naming consistency, and the nightlyBuildAvailable() computed property has been renamed to isNightlyBuildAvailable() to more clearly indicate its purpose.
Previously, the version check was incorrectly splitting the version number string by "-g" instead of ".", resulting in an error that prevented the check from properly detecting the version. This commit fixes the bug by updating the version check to split the version number string by ".", which is the correct delimiter for version numbers
I changed the style of this boolean check to be more consistent with the other booleans
This commit adds a change log section to the index.html file of the project. The change log displays the commit messages for the most recent commits on the "nightly" branch of the LizardByte/Sunshine repository. The maximum number of commits displayed is controlled by the "nightlyCommitLimit" property, which is set to 20. If the user is more than 20 commits behind the current version, a warning message is displayed. The commit messages are fetched using the GitHub API and are displayed in an unordered list.
Also fixes a bug with the commit tracking, it will now properly stop at the latest commit.
I've also changed the order of the boolean checks in the method so it doesn't short circuit and exit out early, it will check for version first.
… nightly_change_log
This comment was marked as spam.
This comment was marked as spam.
Member
|
This PR is stale because it has been open for 90 days with no activity. Comment or remove the stale label, otherwise this will be closed in 10 days. |
Member
|
This PR was closed because it has been stalled for 10 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates notifications for nightly builds to display the change log for up to 20 commits from latest Nightly Version of Sunshine. In addition, the change log will now link to the pull request if applicable.
This has a dependency to #1073
Changes Made:
Added a new section to display the change log for the latest Nightly Version of Sunshine.
Created retrieveNightlyChangelog method to fetch the commits for the nightly build from the GitHub API and retrieve the commit messages for the commits since it was installed.
Add getPrNumber method to search for a PR number in the commit message and return it to be used for creating links to a pull request.
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.