fix(macos): properly handle accessibility permission#2508
fix(macos): properly handle accessibility permission#2508Hazer wants to merge 7 commits intoLizardByte:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2508 +/- ##
=======================================
Coverage 11.59% 11.59%
=======================================
Files 92 92
Lines 17358 17358
Branches 8106 8106
=======================================
Hits 2013 2013
Misses 12853 12853
Partials 2492 2492
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Needs test coverage on the new methods |
|
If we are going to test this, this has to be tested only on CI, this cannot be tested on macports test action. |
2340497 to
062d1fb
Compare
|
Waiting for #2550 to create the tests |
062d1fb to
c24e808
Compare
|
This needs to be updated and tested on macOS Sequoia before merging. |
d8d4ada to
96505cc
Compare
|
Revisiting this PR, fixing conflicts first to get this on track |
|
Should I include a manual request in the web ui? Or the status saying whether the permission is given or not? @ReenigneArcher |
This sounds like a good idea... should it be a separate PR? |
|
@ReenigneArcher not sure. I may do it in the same, so I can improve the API around it once, cause it may change where it is declared, and as I have some code quality issues to review, I may do it in a single pass |
915c7bf to
a2e3b24
Compare
a2e3b24 to
9ee1221
Compare
|
|
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks! |
# Conflicts: # src/platform/macos/display.mm # src/platform/macos/input.cpp # src/platform/macos/misc.h # src/platform/macos/misc.mm
@Hazer I brought this PR up to date. I'd like to get it in, even if there are no unit tests at this time. What do you think? |
|
|
|
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks! |
|
This PR was closed because it has been stalled for 10 days with no activity. |




Description
Check for macOS Accessibility permission to allow mouse and keyboard input events to work properly.
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.