Skip to content

Add batch files to add and remove firewall rules#308

Closed
sitiom wants to merge 3 commits intoLizardByte:nightlyfrom
sitiom:firewall-rules
Closed

Add batch files to add and remove firewall rules#308
sitiom wants to merge 3 commits intoLizardByte:nightlyfrom
sitiom:firewall-rules

Conversation

@sitiom
Copy link
Contributor

@sitiom sitiom commented Aug 8, 2022

Accidentally deleted my fork, so #205 cannot be reopened.

Description

This change adds batch files to programmatically add and remove sunshine firewall rules. In my use case, if I run sunshinevc without opening Sunshine for the first time, Sunshine will silently fail and would not be discoverable within the network, as normally, you would have to deal with this popup first which sunshinevc wouldn't show:
image

Screenshot

It works as intended (admin required, of course):
image
image

Issues Fixed or Closed

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher
Copy link
Member

This doesn't fix #206 ... Adding these files has no effect on the installer.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 8, 2022

This doesn't fix #206 ... Adding these files has no effect on the installer.

You added that yourself, didn't you?
image

@ReenigneArcher
Copy link
Member

This doesn't fix #206 ... Adding these files has no effect on the installer.

You added that yourself, didn't you?

I guess I did in the old PR.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants