Add batch files to add and remove firewall rules#308
Closed
sitiom wants to merge 3 commits intoLizardByte:nightlyfrom
sitiom:firewall-rules
Closed
Add batch files to add and remove firewall rules#308sitiom wants to merge 3 commits intoLizardByte:nightlyfrom sitiom:firewall-rules
sitiom wants to merge 3 commits intoLizardByte:nightlyfrom
sitiom:firewall-rules
Conversation
Member
|
This doesn't fix #206 ... Adding these files has no effect on the installer. |
Contributor
Author
|
Member
I guess I did in the old PR. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Accidentally deleted my fork, so #205 cannot be reopened.
Description
This change adds batch files to programmatically add and remove sunshine firewall rules. In my use case, if I run

sunshinevcwithout opening Sunshine for the first time, Sunshine will silently fail and would not be discoverable within the network, as normally, you would have to deal with this popup first whichsunshinevcwouldn't show:Screenshot
It works as intended (admin required, of course):


Issues Fixed or Closed
Type of Change
Checklist