fix(rtsp): fix RTSP timeout after quitting an app

[cgutman]

Description

Remove permanent side-effect in rtsp_server_t::clear(true) that prevents RTSP server from accepting new connections. I have no idea why this was there, since the destructor of rtsp_server_t should handle teardown of the io_context.

Also a drive-by fix for an unhandled exception I saw when testing this scenario on Linux due to us calling terminate() after we had already successfully terminated the process group.

Screenshot

Issues Fixed or Closed

Fixes #3371

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 11.06%. Comparing base (738a079) to head (c6f7bab).
Report is 86 commits behind head on master.

Files with missing lines	Patch %	Lines
src/process.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #3376    +/-   ##
========================================
  Coverage   11.06%   11.06%            
========================================
  Files          99       99            
  Lines       17237    17236     -1     
  Branches     8035     8033     -2     
========================================
  Hits         1908     1908            
- Misses      12643    12784   +141     
+ Partials     2686     2544   -142     

Flag	Coverage Δ
Linux	8.34% <0.00%> (-0.01%)	⬇️
Windows	5.23% <0.00%> (+<0.01%)	⬆️
macOS-13	13.66% <0.00%> (+0.02%)	⬆️
macOS-14	12.62% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/rtsp.cpp	2.77% <ø> (-0.34%)	⬇️
src/process.cpp	3.21% <0.00%> (+0.25%)	⬆️

... and 21 files with indirect coverage changes