Skip to content

build(windows): sign windows executables#4829

Merged
ReenigneArcher merged 2 commits intomasterfrom
build/windows/sign-windows-executables
Mar 11, 2026
Merged

build(windows): sign windows executables#4829
ReenigneArcher merged 2 commits intomasterfrom
build/windows/sign-windows-executables

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 8, 2026

Description

Adds code signing for Windows executable files and installers using Azure Artifact Signing.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Mar 8, 2026

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher added the roadmap This PR closes a roadmap entry label Mar 8, 2026
@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@4c7df2d). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4829   +/-   ##
=========================================
  Coverage          ?   17.54%           
=========================================
  Files             ?      106           
  Lines             ?    21813           
  Branches          ?     9770           
=========================================
  Hits              ?     3828           
  Misses            ?    13243           
  Partials          ?     4742           
Flag Coverage Δ
Archlinux 12.05% <ø> (?)
FreeBSD-14.3-amd64 13.86% <ø> (?)
Homebrew-ubuntu-22.04 14.36% <ø> (?)
Linux-AppImage 12.54% <ø> (?)
Windows-AMD64 14.49% <ø> (?)
Windows-ARM64 13.11% <ø> (?)
macOS-arm64 18.22% <ø> (?)
macOS-x86_64 16.72% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher force-pushed the build/windows/sign-windows-executables branch from d6290a6 to cfdb036 Compare March 9, 2026 02:28
@ReenigneArcher ReenigneArcher force-pushed the build/windows/sign-windows-executables branch from cfdb036 to 12d8272 Compare March 10, 2026 17:45
Replace SSL.com CodeSignTool-based signing with Azure Artifact Signing via azure/trusted-signing-action. Adds workflow inputs (azure_signing_account, azure_signing_cert_profile, azure_signing_endpoint) and maps AZURE_CLIENT_ID/SECRET/TENANT secrets. Removes CodeSignTool install and legacy SSL.com signing steps, and updates ci.yml to forward Azure signing vars/secrets. Signing steps now conditionally run when publishing and an Azure signing account is provided, and sign both built executables/scripts and installer artifacts.
@ReenigneArcher ReenigneArcher force-pushed the build/windows/sign-windows-executables branch 2 times, most recently from 3a9d8cd to 5e3e0d9 Compare March 10, 2026 20:55
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher merged commit 977045c into master Mar 11, 2026
80 of 114 checks passed
@ReenigneArcher ReenigneArcher deleted the build/windows/sign-windows-executables branch March 11, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roadmap This PR closes a roadmap entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sunshine: code sign exe

1 participant