build(windows): sign windows executables#4829
Merged
ReenigneArcher merged 2 commits intomasterfrom Mar 11, 2026
Merged
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4829 +/- ##
=========================================
Coverage ? 17.54%
=========================================
Files ? 106
Lines ? 21813
Branches ? 9770
=========================================
Hits ? 3828
Misses ? 13243
Partials ? 4742
Flags with carried forward coverage won't be shown. Click here to find out more. |
d6290a6 to
cfdb036
Compare
cfdb036 to
12d8272
Compare
Replace SSL.com CodeSignTool-based signing with Azure Artifact Signing via azure/trusted-signing-action. Adds workflow inputs (azure_signing_account, azure_signing_cert_profile, azure_signing_endpoint) and maps AZURE_CLIENT_ID/SECRET/TENANT secrets. Removes CodeSignTool install and legacy SSL.com signing steps, and updates ci.yml to forward Azure signing vars/secrets. Signing steps now conditionally run when publishing and an Azure signing account is provided, and sign both built executables/scripts and installer artifacts.
3a9d8cd to
5e3e0d9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Adds code signing for Windows executable files and installers using Azure Artifact Signing.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage