nvenc, amdvce: rework all user presets/options#623
nvenc, amdvce: rework all user presets/options#623ReenigneArcher merged 2 commits intoLizardByte:nightlyfrom
Conversation
da3fc6d to
04e9618
Compare
650da32 to
225a6e5
Compare
|
What is the reason for VBR as default? Nvidia recommends CBR for cloud gaming/streaming. EDIT: wrong link to recommendations section |
225a6e5 to
b207fa4
Compare
ReenigneArcher
left a comment
There was a problem hiding this comment.
I just have a minor suggestion to docs
a8db6d0 to
7195b4d
Compare
|
I've also updated the AMF encoder, as I noticed that the "Quality" setting differs between codecs and therefore requires special handling. An outstanding issue with this PR is that it may break macos due to the nv/amf headers not being available. Would you prefer that I hardcode the definitions that needs these headers (and thus lose future-proofing compatibility), or exclude the sections via something like If opting for the first option seems best, future-proofing could be improved if we make <libavcodec/nvenc.h> available to Sunshine's build include path as well. |
172b294 to
0131257
Compare
3556a87 to
ab0c100
Compare
* Presets: remove deprecated presets; add new p1-p7 presets; set "p4" as default. * Tuning: add new tuning options; set "ull" as default. * Rate control: remove deprecated options; set "cbr" as default. * Web UI: keep case consistency (NVEnc -> NVENC, all drop-down options as lowercase); ensure all default options are clearly indicated. * Coder: clarify H264-only status; keep default to "auto". * Ensure all default presets are correctly identical between C++ and HTML code. * To improve future compatibility, refer to all possible options via same definitions used in ffmpeg code via nvenc headers. * Docs: update with new profile and tuning options.
* Quality - fix different values used between codecs; set "balanced" as default. * Rate control: remove "auto"; set "vbr_latency" as default. * Web UI: keep consistency (AMD AMF -> AMF, all drop-down options as lowercase); ensure all default options are clearly indicated. * Coder: clarify H264-only status; keep default to "auto". * Ensure all default presets are correctly identical between C++ and HTML code. * To improve future compatibility, refer to all possible options via same definitions used in ffmpeg code via AMF headers. * Docs: update with new options and descriptions.
ab0c100 to
7f213dd
Compare
Description
nvenc: rework all user presets/options
ensure all default options are clearly indicated.
definitions used in ffmpeg code via nvenc headers.
amdvce: rework all user presets/options
ensure all default options are clearly indicated.
definitions used in ffmpeg code via AMF headers.
Screenshot
Issues Fixed or Closed
Closes #211
TODO
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.