Graceful termination on shutdown, logoff, and service stop#647
Merged
ReenigneArcher merged 3 commits intoLizardByte:nightlyfrom Dec 29, 2022
Merged
Graceful termination on shutdown, logoff, and service stop#647ReenigneArcher merged 3 commits intoLizardByte:nightlyfrom
ReenigneArcher merged 3 commits intoLizardByte:nightlyfrom
Conversation
3a0aa54 to
188e358
Compare
Collaborator
Author
|
I ended up finding and fixing some additional bugs after doing some testing in another branch that is fixing/removing |
Contributor
|
It would be great if the "Press enter to continue" was disabled for Linux all together. You would not normally need to hold a terminal window open in Linux so this has always been mildly irritating. |
Member
Same for Windows to be honest. |
Fixes reverting audio device to default while streaming during logoff/shutdown
188e358 to
2766f3f
Compare
11 tasks
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several issues handling service stop, shutdown, and logoff on Windows:
WM_ENDSESSIONto allow Sunshine to gracefully close itself when the user session is ending. Unfortunately, we have to use the hidden window solution rather than the simplerSetConsoleCtrlHandler()API because the display capture APIs we use causegdi32.dllto be loaded.Screenshot
Issues Fixed or Closed
Fixes Sunshine not reverting back to the default audio output after logoff, shutdown, or service stop while streaming
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.