Skip to content

Remove/fix calls to std::abort()#648

Merged
ReenigneArcher merged 3 commits intoLizardByte:nightlyfrom
cgutman:remove_aborts
Dec 29, 2022
Merged

Remove/fix calls to std::abort()#648
ReenigneArcher merged 3 commits intoLizardByte:nightlyfrom
cgutman:remove_aborts

Conversation

@cgutman
Copy link
Collaborator

@cgutman cgutman commented Dec 29, 2022

Description

We shouldn't be aborting for non-fatal things like failing to deregister an mDNS service, failing to send input to the ViGEmBus driver, or an undo command returning a non-zero exit code.

This also reworks the mDNS registration code for Windows to address an issue that was causing us to consistently (at least on my machine) hit the the std::abort() in publish.cpp.

I also included a fix for a crash in KMS grab that I initially thought was a std::abort() before actually debugging it.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@KuleRucket
Copy link
Contributor

process.cpp logs some "Executing..." statements as debug and some as info. Could you make them all info while you're at it?

We have:
BOOST_LOG(info) << "Executing: ["sv << proc.cmd << "] in ["sv << working_dir << ']';
BOOST_LOG(debug) << "Executing: ["sv << cmd << ']';
BOOST_LOG(info) << "Executing: ["sv << cmd << ']';
BOOST_LOG(debug) << "Executing [Desktop]"sv;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants