Skip to content

Add TPCircularBuffer submodule#81

Closed
sitiom wants to merge 1 commit intoLizardByte:masterfrom
sitiom:tpcircularbuffer
Closed

Add TPCircularBuffer submodule#81
sitiom wants to merge 1 commit intoLizardByte:masterfrom
sitiom:tpcircularbuffer

Conversation

@sitiom
Copy link
Contributor

@sitiom sitiom commented Mar 2, 2022

Description

I was trying to build sunshine on macOS when I noticed the TPCircularBuffer submodule was missing.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the documentation blocks for new or existing components

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Pull requests must be made to the nightly branch. Thanks.

@sitiom sitiom closed this Mar 2, 2022
@ReenigneArcher
Copy link
Member

Why did you close the PR? Also, Please leave the checklist in place.

@sitiom
Copy link
Contributor Author

sitiom commented Mar 2, 2022

#82

@sitiom sitiom deleted the tpcircularbuffer branch March 2, 2022 03:21
@ReenigneArcher
Copy link
Member

You know you can edit the destination branch, right?

@sitiom
Copy link
Contributor Author

sitiom commented Mar 2, 2022

Oh, that's an option? (this branch is also based on master so I'm not sure I can do that either)

@ReenigneArcher
Copy link
Member

Oh, that's an option? (this branch is also based on master so I'm not sure I can do that either)

Yes, just click the edit button. Master and nightly are typically pretty close, if not equal. You'd have to do a rebase if you modified files that were modified by another PR. But in this case no rebase would be needed.

Anyway, we'll work with your other PR. Thanks for submitting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants