Add TPCircularBuffer submodule#81
Closed
sitiom wants to merge 1 commit intoLizardByte:masterfrom
sitiom:tpcircularbuffer
Closed
Add TPCircularBuffer submodule#81sitiom wants to merge 1 commit intoLizardByte:masterfrom sitiom:tpcircularbuffer
sitiom wants to merge 1 commit intoLizardByte:masterfrom
sitiom:tpcircularbuffer
Conversation
|
Pull requests must be made to the |
Member
|
Why did you close the PR? Also, Please leave the checklist in place. |
Contributor
Author
Member
|
You know you can edit the destination branch, right? |
Contributor
Author
|
Oh, that's an option? (this branch is also based on master so I'm not sure I can do that either) |
Member
Yes, just click the edit button. Master and nightly are typically pretty close, if not equal. You'd have to do a rebase if you modified files that were modified by another PR. But in this case no rebase would be needed. Anyway, we'll work with your other PR. Thanks for submitting it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was trying to build sunshine on macOS when I noticed the TPCircularBuffer submodule was missing.
Type of Change
Please delete options that are not relevant.
Checklist