Skip to content

fix!: ensure action names are 17 characters or less#130

Merged
ReenigneArcher merged 1 commit intomasterfrom
fix/ensure-action-names-are-17-characters-or-less
Feb 27, 2026
Merged

fix!: ensure action names are 17 characters or less#130
ReenigneArcher merged 1 commit intomasterfrom
fix/ensure-action-names-are-17-characters-or-less

Conversation

@ReenigneArcher
Copy link
Member

Description

This PR resolves a potential issue where the declaration of an action could exceed 120 characters in yaml with the version comment.

e.g.

uses: LizardByte/actions/actions/check_trailing_spaces@30be428f5c54b82056fe9d63e8c4da4b86130ebe  # v2026.227.132933

By limiting the action names to 17 characters, the total line length should not exceed the 120 character limit, even with the longest possible calver.

This is technically a breaking change, though I don't think anyone is using either of the affected actions yet.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (30be428) to head (9861cf2).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #130   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1566      1566           
  Branches       175       175           
=========================================
  Hits          1566      1566           
Flag Coverage Δ
Linux 100.00% <ø> (ø)
Windows 84.16% <ø> (ø)
macOS 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/trailing_spaces/trailing_spaces.js 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher ReenigneArcher force-pushed the fix/ensure-action-names-are-17-characters-or-less branch from 103f942 to 9861cf2 Compare February 27, 2026 18:38
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher merged commit 70bb8d3 into master Feb 27, 2026
85 of 86 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/ensure-action-names-are-17-characters-or-less branch February 27, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant