Skip to content

fix(issue-sync): Use string.fileId instead of string.file.id#12

Merged
ReenigneArcher merged 1 commit intomasterfrom
fix/use-string.fieldId-for-crowdin-url
Mar 16, 2026
Merged

fix(issue-sync): Use string.fileId instead of string.file.id#12
ReenigneArcher merged 1 commit intomasterfrom
fix/use-string.fieldId-for-crowdin-url

Conversation

@ReenigneArcher
Copy link
Member

Description

Read the file ID from string.fileId when building Crowdin editor URLs. Updated buildIssueBody to use crowdinIssue.string?.fileId and adjusted unit tests to reflect the new shape (including renaming the test that references fileId). This aligns the code with the CrowdIn payload shape and preserves the fallback to the project page when fileId is absent.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Read the file ID from string.fileId when building Crowdin editor URLs. Updated buildIssueBody to use crowdinIssue.string?.fileId and adjusted unit tests to reflect the new shape (including renaming the test that references fileId). This aligns the code with the CrowdIn payload shape and preserves the fallback to the project page when fileId is absent.
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (667ce76) to head (fcdf610).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          278       278           
  Branches        59        59           
=========================================
  Hits           278       278           
Files with missing lines Coverage Δ
src/sync-crowdin-issues.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 667ce76...fcdf610. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher ReenigneArcher merged commit fbad5c9 into master Mar 16, 2026
14 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/use-string.fieldId-for-crowdin-url branch March 16, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant