Merged
Conversation
ReenigneArcher
force-pushed
the
feat/add-language-managers
branch
from
7bb553d to
1d1f331
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 186 276 +90
Branches 38 59 +21
=========================================
+ Hits 186 276 +90
Continue to review full report in Codecov by Sentry.
|
Introduce explicit type and language GitHub labels (with LANG_LABEL_COLOR and TYPE_LABEL_COLOR) and helper functions: getTypeLabel, getLanguageLabels, buildIssueLabels, and ensureIssueLabels. Replace ensureCrowdinLabel with a generic ensureLabel, keep ensureCrowdinLabel as a wrapper, and make createGithubIssue accept an explicit labels array. Sync logic now builds a minimal patch (title/body/labels), ensures labels exist before applying them, and avoids unnecessary updates; createNewIssue ensures labels are created prior to issue creation. Tests updated to cover label generation, creation, and the refined sync behavior.
Add fetchProjectSlug with an in-memory cache to resolve Crowdin project identifiers (slugs) and avoid repeated API calls. Update buildIssueBody to accept a projectSlug, construct deep links to the Crowdin editor when possible, and conditionally include File and String ID rows in the issue table; omit the 'View on Crowdin' link when no slug is available. Propagate projectSlug through syncProject, syncExistingIssue, and createNewIssue (fetching the slug in parallel with issues). Export fetchProjectSlug and projectSlugCache for testing. Update tests to mock projectsGroupsApi.getProject and add coverage for slug/linking, file/string metadata, caching, and updated call signatures.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Primary changes:
Additional changes:
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage