Skip to content

fix: Boost is now properly found using find_package #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 3 commits into from
Jun 27, 2024
Merged

fix: Boost is now properly found using find_package #50

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1aeef1
fix: Boost is now properly found using find_package
FrogTheFrog Jun 27, 2024
2ddb020
meh
FrogTheFrog Jun 27, 2024
e0c5d6c
meh 2
FrogTheFrog Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions cmake/Boost_DD.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,33 @@
#
include_guard(GLOBAL)

# Limit boost to the required libraries only
set(REQUIRED_HEADER_LIBRARIES
algorithm
scope
preprocessor
uuid
)

find_package(Boost 1.85 QUIET GLOBAL)
if(NOT Boost_FOUND)
message(STATUS "Boost v1.85.x package not found in the system. Falling back to FetchContent.")
include(FetchContent)

# Avoid warning about DOWNLOAD_EXTRACT_TIMESTAMP in CMake 3.24:
if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.24.0")
cmake_policy(SET CMP0135 NEW)
endif()

# Limit boost to the required libraries only
set(BOOST_INCLUDE_LIBRARIES
algorithm
scope
uuid)
set(BOOST_INCLUDE_LIBRARIES ${REQUIRED_HEADER_LIBRARIES})
FetchContent_Declare(
Boost
URL https://github.com/boostorg/boost/releases/download/boost-1.85.0/boost-1.85.0-cmake.tar.xz
URL_HASH MD5=BADEA970931766604D4D5F8F4090B176
DOWNLOAD_EXTRACT_TIMESTAMP
)
FetchContent_MakeAvailable(Boost)
else()
# For whatever reason the Boost::headers from find_package is not the same as the one from FetchContent
# (differ in linked targets).
# Also, FetchContent creates Boost::<lib> targets, whereas find_package does not. Since we cannot extend
# Boost::headers as it is an ALIAS target, this is the workaround:
foreach (lib ${REQUIRED_HEADER_LIBRARIES})
add_library(Boost::${lib} ALIAS Boost::headers)
endforeach ()
endif()