Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

ci(plexhints)!: drop python3 support#252

Merged
ReenigneArcher merged 1 commit intomasterfrom
ci(plexhints)!-drop-python3-support
May 16, 2024
Merged

ci(plexhints)!: drop python3 support#252
ReenigneArcher merged 1 commit intomasterfrom
ci(plexhints)!-drop-python3-support

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 15, 2024

Description

Drop Python 3.x support, as plexhints is meant to run in Plex, which is python 2.7. This does not affect the github action, which still uses python 3.11.

This should significantly lighten the load on dependabot PRs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the ci(plexhints)!-drop-python3-support branch from 722b393 to 061f866 Compare May 16, 2024 01:11
@codecov
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (3815503) to head (4a3a3a7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   80.49%   78.77%   -1.73%     
==========================================
  Files          24       24              
  Lines        2907     2869      -38     
==========================================
- Hits         2340     2260      -80     
- Misses        567      609      +42     
Flag Coverage Δ
Python-2.7-Linux 78.77% <ø> (ø)
Python-2.7-Windows ?
Python-2.7-macOS 78.77% <ø> (ø)
Python-3.10-Linux ?
Python-3.10-Windows ?
Python-3.10-macOS ?
Python-3.11-Linux ?
Python-3.11-Windows ?
Python-3.11-macOS ?
Python-3.8-Linux ?
Python-3.8-Windows ?
Python-3.8-macOS ?
Python-3.9-Linux ?
Python-3.9-Windows ?
Python-3.9-macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci(plexhints)!-drop-python3-support branch from 061f866 to 4a3a3a7 Compare May 16, 2024 01:20
@ReenigneArcher ReenigneArcher merged commit 03f3978 into master May 16, 2024
@ReenigneArcher ReenigneArcher deleted the ci(plexhints)!-drop-python3-support branch May 16, 2024 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 3 support for Plexhints python module

1 participant