fix(github): fixes for assigning github role#375
Merged
ReenigneArcher merged 1 commit intomasterfrom Dec 15, 2024
Merged
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 67.58% 67.51% -0.07%
==========================================
Files 21 21
Lines 1092 1096 +4
==========================================
+ Hits 738 740 +2
- Misses 354 356 +2
|
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/discord/tasks.py:244
- [nitpick] The role name 'github-user' is inconsistent with the previous 'github-users'. Ensure this change is intentional and consistent across the codebase.
user_data['roles'].append('github-user')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
A small fix for applying or removing roles to users. The previous code only worked during unit tests, bot not in production.
Also, adds a small piece of info to the readme.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist