Skip to content

fix(database): ensure git uses proper credentials#403

Merged
ReenigneArcher merged 1 commit intomasterfrom
fix/database/ensure-git-uses-proper-credentials
May 16, 2025
Merged

fix(database): ensure git uses proper credentials#403
ReenigneArcher merged 1 commit intomasterfrom
fix/database/ensure-git-uses-proper-credentials

Conversation

@ReenigneArcher
Copy link
Member

Description

#401 did not include any mechanism to clone or push to private git repos. This PR adds env variables and uses them to clone and push to the private repo.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 62.58%. Comparing base (a67430e) to head (ad25e78).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/common/database.py 3.12% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   63.93%   62.58%   -1.36%     
==========================================
  Files          21       21              
  Lines        1220     1248      +28     
==========================================
+ Hits          780      781       +1     
- Misses        440      467      +27     
Files with missing lines Coverage Δ
src/common/database.py 40.58% <3.12%> (-7.30%) ⬇️

@ReenigneArcher ReenigneArcher force-pushed the fix/database/ensure-git-uses-proper-credentials branch from d34f5e5 to ad25e78 Compare May 16, 2025 23:51
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher merged commit c2bbb6b into master May 16, 2025
14 of 15 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/database/ensure-git-uses-proper-credentials branch May 16, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant