Skip to content

build(docker): remove unnecessary args#404

Merged
LizardByte-bot merged 1 commit intomasterfrom
build/docker/remove-unnecessary-args
May 17, 2025
Merged

build(docker): remove unnecessary args#404
LizardByte-bot merged 1 commit intomasterfrom
build/docker/remove-unnecessary-args

Conversation

@ReenigneArcher
Copy link
Member

Description

env variables are not necessary in Dockerfile, unless used at build time

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.58%. Comparing base (c2bbb6b) to head (e08c85f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   62.58%   62.58%           
=======================================
  Files          21       21           
  Lines        1248     1248           
=======================================
  Hits          781      781           
  Misses        467      467           

@LizardByte-bot LizardByte-bot merged commit ff7903d into master May 17, 2025
15 checks passed
@LizardByte-bot LizardByte-bot deleted the build/docker/remove-unnecessary-args branch May 17, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants