Skip to content

fix: build tests and docs only if main project#25

Merged
ReenigneArcher merged 3 commits intoLizardByte:masterfrom
FrogTheFrog:patch-1
Aug 12, 2024
Merged

fix: build tests and docs only if main project#25
ReenigneArcher merged 3 commits intoLizardByte:masterfrom
FrogTheFrog:patch-1

Conversation

@FrogTheFrog
Copy link

Description

Build tests and docs only if main project. Also applied some fixes from libdisplaydevice.

Removed the -ggdb flag as I could not find it anywhere in the provided link...

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher
Copy link
Member

-ggdb was added here: LizardByte/Sunshine#2512

Whether it's useful... I don't know.

@FrogTheFrog
Copy link
Author

-ggdb was added here: LizardByte/Sunshine#2512

Whether it's useful... I don't know.

Should we keep it?

@ReenigneArcher
Copy link
Member

I think so... I incorporated it from your change in ldd. But in Sunshine we can't make the whole build a debug build, so only the tests are in debug.

Or for this library maybe need more of your other changes in ldd... probably for later.

@FrogTheFrog
Copy link
Author

FrogTheFrog commented Aug 9, 2024

But you are already building both release and debug builds for Sunshine. Same for this one when tests are built 🤔

@sonarqubecloud
Copy link

@ReenigneArcher
Copy link
Member

Why are your PRs giving so much trouble with codecov? 🤔

@ReenigneArcher ReenigneArcher merged commit ebbd14f into LizardByte:master Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants