fix: build tests and docs only if main project#25
Merged
ReenigneArcher merged 3 commits intoLizardByte:masterfrom Aug 12, 2024
Merged
fix: build tests and docs only if main project#25ReenigneArcher merged 3 commits intoLizardByte:masterfrom
ReenigneArcher merged 3 commits intoLizardByte:masterfrom
Conversation
Member
|
Whether it's useful... I don't know. |
Author
Should we keep it? |
Member
|
I think so... I incorporated it from your change in ldd. But in Sunshine we can't make the whole build a debug build, so only the tests are in debug. Or for this library maybe need more of your other changes in ldd... probably for later. |
Author
|
But you are already building both release and debug builds for Sunshine. Same for this one when tests are built 🤔 |
|
Member
|
Why are your PRs giving so much trouble with codecov? 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Build tests and docs only if main project. Also applied some fixes from libdisplaydevice.
Removed the
-ggdbflag as I could not find it anywhere in the provided link...Type of Change
.github/...)Checklist