Statement, Rationale, Implications #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statement, Rationale, Runtime implications
sanderke
changed the title
sanderke
force-pushed
the
alexander-verduidelijken
branch
from
e5b624a to
8367872
Compare
Create publishers.yml
Collaborator
|
@sanderke kan jij mijn changes reviewen? ik kan jou niet als reviewer aanmerken aangezien jij oorspronkelijk het pull request hebt gedaan. |
Member
Author
|
Het ziet er prima uit. Ik twijfel echter of API-56 wel als testbaar beschouwd kan worden:
De test kijkt enkel of het versienummer een mogelijk geldig SemVer-nummer is. |
Collaborator
De testset op Developer.overheid is herzien en draait nu op basis van nieuwe tooling. zie ook https://gitlab.com/commonground/don/adr-validator. De verduidelijking die we echter wilde doorvoeren is gereed en daarom zal ik deze branche mergen met de develop branche |
mrtn78
added
the
Status: Klaar voor release
mrtn78
added
Status: Ter goedkeuring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview pagina