Skip to content

Conversation

@LossyDragon
Copy link
Collaborator

@LossyDragon LossyDragon commented May 2, 2025

Description

Originally from SK issue 1531 and SK PR 1532

AsyncJobManager shoudn't accept new jobs after SetTimeoutsEnabled(false) called.
An AsyncJob should cancel immidiatly because there is no chance to be completed(we are disconnected at this point) and also no options to be canceled because the calcellation timer is stopped.

Also added isCompletedExceptionally on most Job tests. With farily recent fixes, this seems to be working correctly for all but 2 tests.

Checklist

  • Code compiles correctly
  • All tests passing
  • Samples run successfully
  • Extended the README / documentation, if necessary

@LossyDragon
Copy link
Collaborator Author

CI runners acting up again. Second build attempt completed.

@LossyDragon
Copy link
Collaborator Author

Relay from SK release notes for this specific change:

This is technically a breaking change if you relied on this behaviour.

@LossyDragon LossyDragon merged commit 2ab2eb2 into Longi94:master May 9, 2025
1 of 2 checks passed
@LossyDragon LossyDragon deleted the jobfail-when-disconnected branch May 9, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant